From: Torsten Duwe <duwe@lst.de>
To: Denis Kirjanov <kda@linux-powerpc.org>
Cc: Steven Rostedt <rostedt@goodmis.org>,
Michael Ellerman <mpe@ellerman.id.au>,
Jiri Kosina <jkosina@suse.cz>,
linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,
live-patching@vger.kernel.org
Subject: Re: [PATCH v4 1/9] ppc64 (le): prepare for -mprofile-kernel
Date: Thu, 26 Nov 2015 13:57:27 +0100 [thread overview]
Message-ID: <20151126125727.GA6484@lst.de> (raw)
In-Reply-To: <CAOJe8K2o-D61zXK-TK3iLRDNu9+qc0kmmn002dA96RF_F7_2Yg@mail.gmail.com>
On Thu, Nov 26, 2015 at 01:12:12PM +0300, Denis Kirjanov wrote:
> On 11/25/15, Torsten Duwe <duwe@lst.de> wrote:
> > + */
> > + return 2;
> I didn't find where you check for this return value.
That's a pure debugging convenience. The return test is for != 0,
so any non-zero value will do. I've encountered situations where
I'd really liked to know _why_ a routine failed/succeeded, visible
in the registers in the debugger.
This is no big thing, I have no strong opinion about this.
Torsten
next prev parent reply other threads:[~2015-11-26 12:57 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-25 16:53 [PATCH v4 0/9] ftrace with regs + live patching for ppc64 LE (ABI v2) Torsten Duwe
2015-11-25 16:23 ` [PATCH v4 1/9] ppc64 (le): prepare for -mprofile-kernel Torsten Duwe
2015-11-26 10:12 ` Denis Kirjanov
2015-11-26 12:57 ` Torsten Duwe [this message]
2015-11-25 16:34 ` [PATCH v4 2/9] ppc64le FTRACE_WITH_REGS implementation Torsten Duwe
2015-11-26 10:04 ` Denis Kirjanov
2015-11-26 12:59 ` Torsten Duwe
2015-12-01 17:29 ` Torsten Duwe
2015-12-01 22:18 ` Michael Ellerman
2016-01-05 15:58 ` Torsten Duwe
2016-01-18 22:22 ` Jiri Kosina
2016-01-18 23:29 ` Michael Ellerman
2015-11-25 16:35 ` [PATCH v4 3/9] ppc use ftrace_modify_all_code default Torsten Duwe
2015-11-25 16:37 ` [PATCH v4 4/9] ppc64 ftrace_with_regs configuration variables Torsten Duwe
2015-12-03 16:20 ` Petr Mladek
2015-12-04 9:01 ` Torsten Duwe
2015-11-25 16:39 ` [PATCH v4 5/9] ppc64 ftrace_with_regs: spare early boot and low level Torsten Duwe
2015-11-25 16:41 ` [PATCH v4 6/9] ppc64 ftrace: disable profiling for some functions Torsten Duwe
2015-11-25 16:42 ` [PATCH v4 7/9] ppc64 ftrace: disable profiling for some files Torsten Duwe
2015-11-25 16:48 ` [PATCH v4 8/9] Implement kernel live patching for ppc64le (ABIv2) Torsten Duwe
2015-12-03 16:24 ` Petr Mladek
2015-12-04 9:06 ` Torsten Duwe
2015-11-25 16:49 ` [PATCH v4 9/9] Enable LIVEPATCH to be configured on ppc64le and add livepatch.o if it is selected Torsten Duwe
2015-12-03 16:00 ` [PATCH v4 0/9] ftrace with regs + live patching for ppc64 LE (ABI v2) Petr Mladek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151126125727.GA6484@lst.de \
--to=duwe@lst.de \
--cc=jkosina@suse.cz \
--cc=kda@linux-powerpc.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=live-patching@vger.kernel.org \
--cc=mpe@ellerman.id.au \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).