From: Al Viro <viro@ZenIV.linux.org.uk>
To: Arnd Bergmann <arnd@arndb.de>
Cc: linuxppc-dev@lists.ozlabs.org,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: more POLL... fun
Date: Fri, 4 Dec 2015 15:21:33 +0000 [thread overview]
Message-ID: <20151204152133.GI22011@ZenIV.linux.org.uk> (raw)
In-Reply-To: <3199712.spOmaGJUoN@wuerfel>
On Fri, Dec 04, 2015 at 10:16:50AM +0100, Arnd Bergmann wrote:
> I don't remember why we put in fasync support, but I have checked the libspe
> implementation and found that it doesn't use it (not a big surprise there).
> It always uses epoll() to get notifications from spufs, and based on your
> explanation I assume everything else (there may have been one or two users
> that used the low-level interfaces rather than libspe) did too.
OK... So should we just rip ->{mfc,ibox,wbox}_fasync out, along with all
three kill_fasync() and ->fasync() instances in there? We obviously need to
leave spufs_{mfc,ibox,wbox}_callback() in place for the sake of those
wake_up_all(&ctx->{mfc,ibox,wbox}_wq); in them...
I mean, fasync in there obviously never been used at all - it never delivered
a single SIGIO, and the first user to try would get the BUG_ON() in fcntl.c
instead. Since nobody complained in more than 10 years...
next prev parent reply other threads:[~2015-12-04 15:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20151127050026.GX22011@ZenIV.linux.org.uk>
[not found] ` <20151127131843.0416fe2b@recife.lan>
[not found] ` <CA+55aFw-9Y6c-wgiXkyFuce7bqA-RQsRUuW6wC42ayoN4nVo6g@mail.gmail.com>
[not found] ` <20151130030427.GY22011@ZenIV.linux.org.uk>
2015-12-04 6:38 ` more POLL... fun Al Viro
2015-12-04 9:16 ` Arnd Bergmann
2015-12-04 15:21 ` Al Viro [this message]
2015-12-04 17:13 ` Arnd Bergmann
2015-12-04 17:30 ` Al Viro
2015-12-04 17:34 ` Arnd Bergmann
2015-12-06 23:58 ` Michael Ellerman
2017-02-16 5:59 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151204152133.GI22011@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=arnd@arndb.de \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).