linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: tlfalcon@linux.vnet.ibm.com
Cc: netdev@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
	nfont@linux.vnet.ibm.com, brking@linux.vnet.ibm.com,
	nguyendo@us.ibm.com, jallen@linux.vnet.ibm.com
Subject: Re: [PATCH net-next] Driver for IBM System i/p VNIC protocol
Date: Sat, 05 Dec 2015 22:25:51 -0500 (EST)	[thread overview]
Message-ID: <20151205.222551.512793392902323297.davem@davemloft.net> (raw)
In-Reply-To: <1449251386-13476-1-git-send-email-tlfalcon@linux.vnet.ibm.com>

From: Thomas Falcon <tlfalcon@linux.vnet.ibm.com>
Date: Fri,  4 Dec 2015 11:49:46 -0600

> +static int ibmvnic_buffs_per_pool = IBMVNIC_BUFFS_PER_POOL;
> +module_param(ibmvnic_buffs_per_pool, int, S_IRUGO);
> +MODULE_PARM_DESC(ibmvnic_buffs_per_pool,
> +		 "IBMVNIC number of buffers per rx pool");

Please do not use module parameters for settings that effect
the basic operation of the driver.

Instead use facilities that are generic and provide the same
user interface for all networking drivers, such as ethtool.

Otherwise users would need to learn a different way to configure the
same thing on different devices, which is not acceptable.

  reply	other threads:[~2015-12-06  3:25 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-04 17:49 [PATCH net-next] Driver for IBM System i/p VNIC protocol Thomas Falcon
2015-12-06  3:25 ` David Miller [this message]
2015-12-07 18:50   ` Thomas Falcon
2015-12-07 19:45     ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151205.222551.512793392902323297.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=brking@linux.vnet.ibm.com \
    --cc=jallen@linux.vnet.ibm.com \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=netdev@vger.kernel.org \
    --cc=nfont@linux.vnet.ibm.com \
    --cc=nguyendo@us.ibm.com \
    --cc=tlfalcon@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).