From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail5.wrs.com (mail5.windriver.com [192.103.53.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 08F531A1045 for ; Wed, 9 Dec 2015 13:26:18 +1100 (AEDT) Date: Tue, 8 Dec 2015 21:04:43 -0500 From: Paul Gortmaker To: Michael Ellerman CC: Benjamin Herrenschmidt , Paul Mackerras , , , Andrew Lunn Subject: Re: [PATCH] sbc8641: drop bogus PHY IRQ entries from DTS file Message-ID: <20151209020443.GL22885@windriver.com> References: <1449614642-8161-1-git-send-email-paul.gortmaker@windriver.com> <1449623421.6028.13.camel@ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" In-Reply-To: <1449623421.6028.13.camel@ellerman.id.au> List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , [Re: [PATCH] sbc8641: drop bogus PHY IRQ entries from DTS file] On 09/12/2015 (Wed 12:10) Michael Ellerman wrote: > On Tue, 2015-12-08 at 17:44 -0500, Paul Gortmaker wrote: > > > This file was originally cloned off of the MPC8641D-HPCN reference > > platform, which actually had a PHY IRQ line connected. However > > this board does not. The bogus entry was largely inert and went > > undetected until commit 321beec5047af83db90c88114b7e664b156f49fe > > ("net: phy: Use interrupts when available in NOLINK state") was > > added to the tree. > > > > With the above commit, the board fails to NFS boot since it sits > > waiting for a PHY IRQ event that of course never arrives. Removing > > the bogus entries from the DTS file fixes the issue. > > Commit 321beec5047a ("net: phy: Use interrupts when available in NOLINK state") > went into 4.4-rc2, so this is a fix for 4.4 right? Correct, but I'm guessing there are not thousands of users of this board out there, so it probably doesn't matter a whole lot if it goes in the same release where the regression happened or one release later... P. -- > > cheers >