From: Michael Ellerman <mpe@ellerman.id.au>
To: Anton Blanchard <anton@samba.org>,
benh@kernel.crashing.org, paulus@samba.org, cyrilbur@gmail.com,
scottwood@freescale.com, mikey@neuling.org,
linuxppc-dev@lists.ozlabs.org, Rashmica <rashmicy@gmail.com>
Subject: Re: [v2] powerpc: Call restore_sprs() before _switch()
Date: Mon, 14 Dec 2015 20:47:50 +1100 (AEDT) [thread overview]
Message-ID: <20151214094750.1E3C5140323@ozlabs.org> (raw)
In-Reply-To: <20151210204439.393ce017@kryten>
On Thu, 2015-10-12 at 09:44:39 UTC, Anton Blanchard wrote:
> commit 152d523e6307 ("powerpc: Create context switch helpers save_sprs()
> and restore_sprs()") moved the restore of SPRs after the call to _switch().
>
> There is an issue with this approach - new tasks do not return through
> _switch(), they are set up by copy_thread() to directly return through
> ret_from_fork() or ret_from_kernel_thread(). This means restore_sprs() is
> not getting called for new tasks.
>
> Fix this by moving restore_sprs() before _switch().
>
> Signed-off-by: Anton Blanchard <anton@samba.org>
> Fixes: 152d523e6307 ("powerpc: Create context switch helpers save_sprs() and restore_sprs()")
Applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/20dbe67062062c2a790832f0
cheers
prev parent reply other threads:[~2015-12-14 9:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-10 9:44 [PATCH v2] powerpc: Call restore_sprs() before _switch() Anton Blanchard
2015-12-14 9:47 ` Michael Ellerman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151214094750.1E3C5140323@ozlabs.org \
--to=mpe@ellerman.id.au \
--cc=anton@samba.org \
--cc=benh@kernel.crashing.org \
--cc=cyrilbur@gmail.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mikey@neuling.org \
--cc=paulus@samba.org \
--cc=rashmicy@gmail.com \
--cc=scottwood@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).