From: Michael Ellerman <mpe@ellerman.id.au>
To: Nathan Fontenot <nfont@linux.vnet.ibm.com>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>
Subject: Re: powerpc/pseries: Verify CPU doesn't exist before adding
Date: Thu, 17 Dec 2015 22:57:36 +1100 (AEDT) [thread overview]
Message-ID: <20151217115736.882F7140317@ozlabs.org> (raw)
In-Reply-To: <562A7255.7010607@linux.vnet.ibm.com>
On Fri, 2015-23-10 at 17:45:57 UTC, Nathan Fontenot wrote:
> When DLPAR adding a CPU we should verify that the CPU does not already
> exist. Failure to do so can generate a kernel oops;
>
> [ 9.465585] kernel BUG at arch/powerpc/platforms/pseries/dlpar.c:382!
> [ 9.465796] Oops: Exception in kernel mode, sig: 5 [#1]
>
> This oops can be generated by causing a probe to be performed on a cpu
> by writing to the sysfs cpu probe file (/sys/devices/system/cpu/probe).
> This patch adds a check for the existence of cpu prior to probing the cpu
> so userspace doing the wrong thing won't trigger a BUG_ON().
>
> Signed-off-by: Nathan Fontenot <nfont@linux.vnet.ibm.com>
Applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/1f859adb9253c2010799625822
cheers
prev parent reply other threads:[~2015-12-17 11:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-23 17:45 [PATCH] powerpc/pseries: Verify CPU doesn't exist before adding Nathan Fontenot
2015-10-25 16:30 ` Denis Kirjanov
2015-10-26 19:53 ` Nathan Fontenot
2015-12-17 11:57 ` Michael Ellerman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151217115736.882F7140317@ozlabs.org \
--to=mpe@ellerman.id.au \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=nfont@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).