linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Brian Norris <computersforpeace@gmail.com>
To: Joe Perches <joe@perches.com>
Cc: Michal Marek <mmarek@suse.com>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Anton Blanchard <anton@au1.ibm.com>,
	Ian Munsie <imunsie@au1.ibm.com>,
	Michael Neuling <mikey@neuling.org>,
	linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,
	Olof Johansson <olof@lixom.net>, Arnd Bergmann <arnd@arndb.de>
Subject: [PATCH] misc: cxl: fix build for GCC 4.6.x
Date: Thu, 7 Jan 2016 12:38:39 -0800	[thread overview]
Message-ID: <20160107203839.GA42481@google.com> (raw)
In-Reply-To: <20160107201826.GA120952@google.com>

GCC 4.6.3 does not support -Wno-unused-const-variable. Instead, use the
kbuild infrastructure that checks if this options exists.

Also drop -Werror, since it's harmful, if forced on the user. New GCC's,
or higher warning verbosities (e.g., W=1) can easily kill the build
where they shouldn't.

Suggested-by: Michal Marek <mmarek@suse.com>
Signed-off-by: Brian Norris <computersforpeace@gmail.com>
---

On Thu, Jan 07, 2016 at 12:18:26PM -0800, Brian Norris wrote:
> On Thu, Jan 07, 2016 at 11:57:31AM -0800, Joe Perches wrote:
> > On Thu, 2016-01-07 at 20:44 +0100, Michal Marek wrote:
> > > We have cc-disable-warning for this.
> > 
> > Thanks Michal.
> 
> Cool, thanks! I'll send a patch to use that instead.

 drivers/misc/cxl/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/misc/cxl/Makefile b/drivers/misc/cxl/Makefile
index 6982f603fadc..0163d4d1fd1e 100644
--- a/drivers/misc/cxl/Makefile
+++ b/drivers/misc/cxl/Makefile
@@ -1,4 +1,4 @@
-ccflags-y := -Werror -Wno-unused-const-variable
+ccflags-y := $(call cc-disable-warning, unused-const-variable)
 
 cxl-y				+= main.o file.o irq.o fault.o native.o
 cxl-y				+= context.o sysfs.o debugfs.o pci.o trace.o
-- 
2.6.0.rc2.230.g3dd15c0

  reply	other threads:[~2016-01-07 20:38 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-07 18:54 Build failure: -Wno-unused-const-variable DNE on old GCC Brian Norris
2016-01-07 19:37 ` Joe Perches
2016-01-07 19:44   ` Michal Marek
2016-01-07 19:57     ` Joe Perches
2016-01-07 20:18       ` Brian Norris
2016-01-07 20:38         ` Brian Norris [this message]
2016-01-08  2:12           ` [PATCH] misc: cxl: fix build for GCC 4.6.x Michael Ellerman
2016-01-30 14:20         ` Build failure: -Wno-unused-const-variable DNE on old GCC Maciej W. Rozycki
2016-01-30 17:37           ` Joe Perches
2016-01-07 20:25 ` Arnd Bergmann
2016-01-07 22:51   ` Daniel Axtens
2016-01-07 23:02     ` Brian Norris
2016-01-08  1:31       ` Ian Munsie
2016-01-08  2:07         ` Brian Norris
2016-01-08  2:16           ` Michael Ellerman
2016-01-08 10:14             ` David Laight
2016-01-08  1:33   ` Ian Munsie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160107203839.GA42481@google.com \
    --to=computersforpeace@gmail.com \
    --cc=anton@au1.ibm.com \
    --cc=arnd@arndb.de \
    --cc=imunsie@au1.ibm.com \
    --cc=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mikey@neuling.org \
    --cc=mmarek@suse.com \
    --cc=mpe@ellerman.id.au \
    --cc=olof@lixom.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).