From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ozlabs.org (ozlabs.org [103.22.144.67]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id AC1001A0AF0 for ; Thu, 14 Jan 2016 00:09:26 +1100 (AEDT) In-Reply-To: <1452600863-6294-2-git-send-email-mpe@ellerman.id.au> To: Michael Ellerman , From: Michael Ellerman Cc: ulrich.weigand@de.ibm.com, Anton Blanchard , rostedt@goodmis.org, amodra@gmail.com Subject: Re: [2/2] powerpc/module: Handle R_PPC64_ENTRY relocations Message-Id: <20160113130926.2805B140556@ozlabs.org> Date: Thu, 14 Jan 2016 00:09:25 +1100 (AEDT) List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Tue, 2016-12-01 at 12:14:23 UTC, Michael Ellerman wrote: > From: Ulrich Weigand > > GCC 6 will include changes to generated code with -mcmodel=large, > which is used to build kernel modules on powerpc64le. This was > necessary because the large model is supposed to allow arbitrary > sizes and locations of the code and data sections, but the ELFv2 > global entry point prolog still made the unconditional assumption > that the TOC associated with any particular function can be found > within 2 GB of the function entry point: > > func: > addis r2,r12,(.TOC.-func)@ha > addi r2,r2,(.TOC.-func)@l > .localentry func, .-func > > To remove this assumption, GCC will now generate instead this global > entry point prolog sequence when using -mcmodel=large: > > .quad .TOC.-func > func: > .reloc ., R_PPC64_ENTRY > ld r2, -8(r12) > add r2, r2, r12 > .localentry func, .-func > > The new .reloc triggers an optimization in the linker that will > replace this new prolog with the original code (see above) if the > linker determines that the distance between .TOC. and func is in > range after all. > > Since this new relocation is now present in module object files, > the kernel module loader is required to handle them too. This > patch adds support for the new relocation and implements the > same optimization done by the GNU linker. > > Cc: stable@vger.kernel.org > Signed-off-by: Ulrich Weigand > Signed-off-by: Michael Ellerman Applied to powerpc next. https://git.kernel.org/powerpc/c/a61674bdfc7c2bf909c4010699 cheers