From: Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>
To: Madhavan Srinivasan <maddy@linux.vnet.ibm.com>
Cc: Michael Ellerman <mpe@ellerman.id.au>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Jiri Olsa <jolsa@redhat.com>,
linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] powerpc/perf: Export Power8 generic and cache events to sysfs
Date: Fri, 15 Jan 2016 11:44:00 -0800 [thread overview]
Message-ID: <20160115194400.GA16425@us.ibm.com> (raw)
In-Reply-To: <56978D36.5040005@linux.vnet.ibm.com>
Madhavan Srinivasan [maddy@linux.vnet.ibm.com] wrote:
> > +enum {
> > +#include "power8-events-list.h"
> > +};
> >
>
> IIUC we dont use this enum as a index to
> some array, so can we do something like this?
Possibly, but its already a macro soup and we would add another
layer of indirection? I agree though that the #define and #undefs
are not intuitive. Since it is only a few entries for Power8, was
keeping it consistent with Power7.
Sukadev
next prev parent reply other threads:[~2016-01-15 19:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-11 22:55 [PATCH 1/2] powerpc/perf: Remove PME_ prefix for power7 events Sukadev Bhattiprolu
2016-01-11 22:55 ` [PATCH 2/2] powerpc/perf: Export Power8 generic and cache events to sysfs Sukadev Bhattiprolu
2016-01-14 11:57 ` Madhavan Srinivasan
2016-01-15 19:44 ` Sukadev Bhattiprolu [this message]
2016-03-11 0:30 ` [1/2] powerpc/perf: Remove PME_ prefix for power7 events Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160115194400.GA16425@us.ibm.com \
--to=sukadev@linux.vnet.ibm.com \
--cc=acme@kernel.org \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=maddy@linux.vnet.ibm.com \
--cc=mpe@ellerman.id.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).