linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Viresh Kumar <viresh.kumar@linaro.org>
To: Shilpasri G Bhat <shilpa.bhat@linux.vnet.ibm.com>
Cc: linuxppc-dev@ozlabs.org, linux-kernel@vger.kernel.org,
	rjw@rjwysocki.net, linux-pm@vger.kernel.org, pc@us.ibm.com,
	anton@samba.org, ego@linux.vnet.ibm.com,
	shreyas@linux.vnet.ibm.com, bsingharora@gmail.com,
	mpe@ellerman.id.au
Subject: Re: [PATCH v7 1/6] cpufreq: powernv: Free 'chips' on module exit
Date: Thu, 28 Jan 2016 13:57:00 +0530	[thread overview]
Message-ID: <20160128082700.GH3935@vireshk> (raw)
In-Reply-To: <1453965941-7363-2-git-send-email-shilpa.bhat@linux.vnet.ibm.com>

On 28-01-16, 12:55, Shilpasri G Bhat wrote:
> This will free the dynamically allocated memory of'chips' on
> module exit.

Though it has a 'space' issues before 'chips', but I don't really care
much about that and so you aren't required to resend, unless you have
to send a v8 for something else.

> Signed-off-by: Shilpasri G Bhat <shilpa.bhat@linux.vnet.ibm.com>
> ---
>  drivers/cpufreq/powernv-cpufreq.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/cpufreq/powernv-cpufreq.c b/drivers/cpufreq/powernv-cpufreq.c
> index 547890f..53f980b 100644
> --- a/drivers/cpufreq/powernv-cpufreq.c
> +++ b/drivers/cpufreq/powernv-cpufreq.c
> @@ -612,6 +612,7 @@ static void __exit powernv_cpufreq_exit(void)
>  	unregister_reboot_notifier(&powernv_cpufreq_reboot_nb);
>  	opal_message_notifier_unregister(OPAL_MSG_OCC,
>  					 &powernv_cpufreq_opal_nb);
> +	kfree(chips);
>  	cpufreq_unregister_driver(&powernv_cpufreq_driver);
>  }
>  module_exit(powernv_cpufreq_exit);

Acked-by: Viresh Kumar <viresh.kumar@linaro.org>

-- 
viresh

  parent reply	other threads:[~2016-01-28  8:27 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-28  7:25 [PATCH v7 0/6] cpufreq: powernv: Redesign the presentation of throttle notification and solve bug-fixes in the driver Shilpasri G Bhat
2016-01-28  7:25 ` [PATCH v7 1/6] cpufreq: powernv: Free 'chips' on module exit Shilpasri G Bhat
2016-01-28  8:00   ` Gautham R Shenoy
2016-01-28  8:27   ` Viresh Kumar [this message]
2016-01-28  7:25 ` [PATCH v7 2/6] cpufreq: powernv: Hot-plug safe the kworker thread Shilpasri G Bhat
2016-01-28  7:25 ` [PATCH v7 3/6] cpufreq: powernv: Remove cpu_to_chip_id() from hot-path Shilpasri G Bhat
2016-01-28  8:11   ` Gautham R Shenoy
2016-01-28  8:28   ` Viresh Kumar
2016-01-28  7:25 ` [PATCH v7 4/6] cpufreq: powernv/tracing: Add powernv_throttle tracepoint Shilpasri G Bhat
2016-01-28  7:25 ` [PATCH v7 5/6] cpufreq: powernv: Replace pr_info with trace print for throttle event Shilpasri G Bhat
2016-01-28  8:18   ` Gautham R Shenoy
2016-01-28  8:29   ` Viresh Kumar
2016-01-28  7:25 ` [PATCH v7 6/6] cpufreq: powernv: Add sysfs attributes to show throttle stats Shilpasri G Bhat
2016-01-28  8:34   ` Gautham R Shenoy
2016-01-28  8:40   ` Viresh Kumar
2016-01-28  9:36     ` Shilpasri G Bhat
2016-01-28  9:41       ` Viresh Kumar
2016-01-28  9:54         ` Shilpasri G Bhat
2016-01-28 11:40   ` Viresh Kumar
2016-01-28  8:25 ` [PATCH v7 0/6] cpufreq: powernv: Redesign the presentation of throttle notification and solve bug-fixes in the driver Viresh Kumar
2016-01-28 11:10 ` Balbir Singh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160128082700.GH3935@vireshk \
    --to=viresh.kumar@linaro.org \
    --cc=anton@samba.org \
    --cc=bsingharora@gmail.com \
    --cc=ego@linux.vnet.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=mpe@ellerman.id.au \
    --cc=pc@us.ibm.com \
    --cc=rjw@rjwysocki.net \
    --cc=shilpa.bhat@linux.vnet.ibm.com \
    --cc=shreyas@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).