From: Balbir Singh <bsingharora@gmail.com>
To: Michael Ellerman <mpe@ellerman.id.au>
Cc: Paul Mackerras <paulus@samba.org>,
kgdb-bugreport@lists.sourceforge.net,
linuxppc-dev@lists.ozlabs.org
Subject: [PATCH] Fix kgdb on little endian ppc64le
Date: Mon, 1 Feb 2016 17:03:25 +1100 [thread overview]
Message-ID: <20160201170325.4ec4324e@cotter.ozlabs.ibm.com> (raw)
From: Balbir Singh <bsingharora@gmail.com>
I spent some time trying to use kgdb and debugged my inability to
resume from kgdb_handle_breakpoint(). NIP is not incremented
and that leads to a loop in the debugger.
I've tested this lightly on a virtual instance with KDB enabled.
After the patch, I am able to get the "go" command to work as
expected
Signed-off-by: Balbir Singh <bsingharora@gmail.com>
---
arch/powerpc/kernel/kgdb.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/arch/powerpc/kernel/kgdb.c b/arch/powerpc/kernel/kgdb.c
index e77c3cc..92c8f80 100644
--- a/arch/powerpc/kernel/kgdb.c
+++ b/arch/powerpc/kernel/kgdb.c
@@ -445,7 +445,11 @@ int kgdb_arch_handle_exception(int vector, int signo, int err_code,
* Global data
*/
struct kgdb_arch arch_kgdb_ops = {
+#ifdef __LITTLE_ENDIAN__
+ .gdb_bpt_instr = {0x08, 0x10, 0x82, 0x7d},
+#else
.gdb_bpt_instr = {0x7d, 0x82, 0x10, 0x08},
+#endif /* __LITTLE_ENDIAN__ */
};
static int kgdb_not_implemented(struct pt_regs *regs)
--
2.5.0
next reply other threads:[~2016-02-01 6:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-01 6:03 Balbir Singh [this message]
2016-02-01 10:39 ` [PATCH] Fix kgdb on little endian ppc64le Andrew Donnellan
2016-02-01 23:31 ` Balbir Singh
2016-02-09 10:11 ` Michael Ellerman
2016-02-11 6:03 ` Balbir Singh
2016-02-22 9:45 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160201170325.4ec4324e@cotter.ozlabs.ibm.com \
--to=bsingharora@gmail.com \
--cc=kgdb-bugreport@lists.sourceforge.net \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).