From: Mark Brown <broonie@kernel.org>
To: "Maciej S. Szmigiero" <mail@maciej.szmigiero.name>
Cc: Fabio Estevam <festevam@gmail.com>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
Timur Tabi <timur@tabi.org>,
Nicolin Chen <nicoleotsuka@gmail.com>,
Xiubo Li <Xiubo.Lee@gmail.com>,
Liam Girdwood <lgirdwood@gmail.com>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ASoC: fsl_ssi: remove explicit register defaults
Date: Mon, 1 Feb 2016 21:10:17 +0000 [thread overview]
Message-ID: <20160201211017.GG4455@sirena.org.uk> (raw)
In-Reply-To: <56AF8E9E.5000100@maciej.szmigiero.name>
[-- Attachment #1: Type: text/plain, Size: 525 bytes --]
On Mon, Feb 01, 2016 at 05:58:06PM +0100, Maciej S. Szmigiero wrote:
> Looks like a possible solution would be to change
> regmap_raw_read() to do read using _regmap_read in
> case the cache is bypassed and there is no ->read
> callback defined for regmap implementation.
No, that's completely broken. We can't do a raw read from a regmap that
doesn't offer raw access and we shouldn't pretend to do so. If the
caller is capable of substituting a register by register read the caller
should take responsibility for that.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2016-02-01 21:10 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-18 19:07 [PATCH] ASoC: fsl_ssi: remove explicit register defaults Maciej S. Szmigiero
2016-01-18 22:14 ` Fabio Estevam
2016-02-01 12:05 ` Fabio Estevam
2016-02-01 12:07 ` Maciej S. Szmigiero
2016-02-01 12:13 ` Fabio Estevam
2016-02-01 12:25 ` Maciej S. Szmigiero
2016-02-01 16:58 ` Maciej S. Szmigiero
2016-02-01 21:10 ` Mark Brown [this message]
2016-02-01 21:30 ` Maciej S. Szmigiero
2016-02-01 21:34 ` Fabio Estevam
2016-02-01 21:37 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160201211017.GG4455@sirena.org.uk \
--to=broonie@kernel.org \
--cc=Xiubo.Lee@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=festevam@gmail.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mail@maciej.szmigiero.name \
--cc=nicoleotsuka@gmail.com \
--cc=timur@tabi.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).