From: David Gibson <david@gibson.dropbear.id.au>
To: Anshuman Khandual <khandual@linux.vnet.ibm.com>
Cc: lvivier@redhat.com, thuth@redhat.com, aik@ozlabs.ru,
paulus@samba.org, linuxppc-dev@lists.ozlabs.org
Subject: Re: [RFCv2 6/9] pseries: Add hypercall wrappers for hash page table resizing
Date: Mon, 8 Feb 2016 08:33:38 +1000 [thread overview]
Message-ID: <20160207223338.GA3702@voom> (raw)
In-Reply-To: <56B331CE.5020806@linux.vnet.ibm.com>
[-- Attachment #1: Type: text/plain, Size: 3440 bytes --]
On Thu, Feb 04, 2016 at 04:41:10PM +0530, Anshuman Khandual wrote:
> On 02/02/2016 06:28 AM, David Gibson wrote:
> > On Mon, Feb 01, 2016 at 12:41:31PM +0530, Anshuman Khandual wrote:
> >> On 01/29/2016 10:54 AM, David Gibson wrote:
> >>> This adds the hypercall numbers and wrapper functions for the hash page
> >>> table resizing hypercalls.
> >>>
> >>> These are experimental "platform specific" values for now, until we have a
> >>> formal PAPR update.
> >>>
> >>> It also adds a new firmware feature flat to track the presence of the
> >>> HPT resizing calls.
> >>
> >> Its a flag ....................... ^^^^^^^ here.
> >
> > Oops, thanks.
> >
> >>
> >>>
> >>> Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
> >>> ---
> >>> arch/powerpc/include/asm/firmware.h | 5 +++--
> >>> arch/powerpc/include/asm/hvcall.h | 2 ++
> >>> arch/powerpc/include/asm/plpar_wrappers.h | 12 ++++++++++++
> >>> arch/powerpc/platforms/pseries/firmware.c | 1 +
> >>> 4 files changed, 18 insertions(+), 2 deletions(-)
> >>>
> >>> diff --git a/arch/powerpc/include/asm/firmware.h b/arch/powerpc/include/asm/firmware.h
> >>> index b062924..32435d2 100644
> >>> --- a/arch/powerpc/include/asm/firmware.h
> >>> +++ b/arch/powerpc/include/asm/firmware.h
> >>> @@ -42,7 +42,7 @@
> >>> #define FW_FEATURE_SPLPAR ASM_CONST(0x0000000000100000)
> >>> #define FW_FEATURE_LPAR ASM_CONST(0x0000000000400000)
> >>> #define FW_FEATURE_PS3_LV1 ASM_CONST(0x0000000000800000)
> >>> -/* Free ASM_CONST(0x0000000001000000) */
> >>> +#define FW_FEATURE_HPT_RESIZE ASM_CONST(0x0000000001000000)
> >>> #define FW_FEATURE_CMO ASM_CONST(0x0000000002000000)
> >>> #define FW_FEATURE_VPHN ASM_CONST(0x0000000004000000)
> >>> #define FW_FEATURE_XCMO ASM_CONST(0x0000000008000000)
> >>> @@ -66,7 +66,8 @@ enum {
> >>> FW_FEATURE_MULTITCE | FW_FEATURE_SPLPAR | FW_FEATURE_LPAR |
> >>> FW_FEATURE_CMO | FW_FEATURE_VPHN | FW_FEATURE_XCMO |
> >>> FW_FEATURE_SET_MODE | FW_FEATURE_BEST_ENERGY |
> >>> - FW_FEATURE_TYPE1_AFFINITY | FW_FEATURE_PRRN,
> >>> + FW_FEATURE_TYPE1_AFFINITY | FW_FEATURE_PRRN |
> >>> + FW_FEATURE_HPT_RESIZE,
> >>> FW_FEATURE_PSERIES_ALWAYS = 0,
> >>> FW_FEATURE_POWERNV_POSSIBLE = FW_FEATURE_OPAL,
> >>> FW_FEATURE_POWERNV_ALWAYS = 0,
> >>> diff --git a/arch/powerpc/include/asm/hvcall.h b/arch/powerpc/include/asm/hvcall.h
> >>> index e3b54dd..195e080 100644
> >>> --- a/arch/powerpc/include/asm/hvcall.h
> >>> +++ b/arch/powerpc/include/asm/hvcall.h
> >>> @@ -293,6 +293,8 @@
> >>>
> >>> /* Platform specific hcalls, used by KVM */
> >>> #define H_RTAS 0xf000
> >>> +#define H_RESIZE_HPT_PREPARE 0xf003
> >>> +#define H_RESIZE_HPT_COMMIT 0xf004
> >>
> >> This sound better and matches FW_FEATURE_HPT_RESIZE ?
> >
> > I'm not quite sure what you're suggesting here.
> >
> >> #define H_HPT_RESIZE_PREPARE 0xf003
> >> #define H_HPT_RESIZE_COMMIT 0xf004
>
> Just little bit of change of name of the macro like this
>
>
> H_RESIZE_HPT_PREPARE --> H_HPT_RESIZE_PREPARE
> H_RESIZE_HPT_COMMIT --> H_HPT_RESIZE_COMMIT
Oh, I see. Actually, I'm trying to standardize on "resize hpt" rather
than "hpt resize" everywhere.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-02-07 23:11 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-29 5:23 [RFCv2 0/9] PAPR hash page table resizing (guest side) David Gibson
2016-01-29 5:23 ` [RFCv2 1/9] memblock: Don't mark memblock_phys_mem_size() as __init David Gibson
2016-02-01 5:50 ` Anshuman Khandual
2016-02-08 2:46 ` Paul Mackerras
2016-01-29 5:23 ` [RFCv2 2/9] arch/powerpc: Clean up error handling for htab_remove_mapping David Gibson
2016-02-01 5:54 ` Anshuman Khandual
2016-02-08 2:48 ` Paul Mackerras
2016-01-29 5:23 ` [RFCv2 3/9] arch/powerpc: Handle removing maybe-present bolted HPTEs David Gibson
2016-02-01 5:58 ` Anshuman Khandual
2016-02-02 1:08 ` David Gibson
2016-02-02 13:49 ` Denis Kirjanov
2016-02-08 2:54 ` Paul Mackerras
2016-02-09 0:43 ` David Gibson
2016-01-29 5:23 ` [RFCv2 4/9] arch/powerpc: Clean up memory hotplug failure paths David Gibson
2016-02-01 6:29 ` Anshuman Khandual
2016-02-02 15:04 ` Nathan Fontenot
2016-02-03 4:31 ` David Gibson
2016-02-08 5:47 ` Paul Mackerras
2016-01-29 5:23 ` [RFCv2 5/9] arch/powerpc: Split hash page table sizing heuristic into a helper David Gibson
2016-02-01 7:04 ` Anshuman Khandual
2016-02-02 1:04 ` David Gibson
2016-02-04 10:56 ` Anshuman Khandual
2016-02-08 5:57 ` Paul Mackerras
2016-01-29 5:24 ` [RFCv2 6/9] pseries: Add hypercall wrappers for hash page table resizing David Gibson
2016-02-01 7:11 ` Anshuman Khandual
2016-02-02 0:58 ` David Gibson
2016-02-04 11:11 ` Anshuman Khandual
2016-02-07 22:33 ` David Gibson [this message]
2016-02-08 5:58 ` Paul Mackerras
2016-01-29 5:24 ` [RFCv2 7/9] pseries: Add support for hash " David Gibson
2016-02-01 8:31 ` Anshuman Khandual
2016-02-01 11:04 ` David Gibson
2016-02-08 5:59 ` Paul Mackerras
2016-01-29 5:24 ` [RFCv2 8/9] pseries: Advertise HPT resizing support via CAS David Gibson
2016-02-01 8:36 ` Anshuman Khandual
2016-02-08 6:00 ` Paul Mackerras
2016-01-29 5:24 ` [RFCv2 9/9] pseries: Automatically resize HPT for memory hot add/remove David Gibson
2016-02-01 8:51 ` Anshuman Khandual
2016-02-01 10:55 ` David Gibson
2016-02-08 6:01 ` Paul Mackerras
2016-02-01 5:50 ` [RFCv2 0/9] PAPR hash page table resizing (guest side) Anshuman Khandual
2016-02-02 0:57 ` David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160207223338.GA3702@voom \
--to=david@gibson.dropbear.id.au \
--cc=aik@ozlabs.ru \
--cc=khandual@linux.vnet.ibm.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=lvivier@redhat.com \
--cc=paulus@samba.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).