From: Michael Ellerman <mpe@ellerman.id.au>
To: Cyril Bur <cyrilbur@gmail.com>, linuxppc-dev@ozlabs.org
Cc: mikey@neuling.org, anton@samba.org
Subject: Re: [v3, 6/9] powerpc: Prepare for splitting giveup_{fpu, altivec, vsx} in two
Date: Wed, 10 Feb 2016 18:51:33 +1100 (AEDT) [thread overview]
Message-ID: <20160210075134.07A0B140324@ozlabs.org> (raw)
In-Reply-To: <1453337749-15506-7-git-send-email-cyrilbur@gmail.com>
On Thu, 2016-21-01 at 00:55:46 UTC, Cyril Bur wrote:
> This prepares for the decoupling of saving {fpu,altivec,vsx} registers and
> marking {fpu,altivec,vsx} as being unused by a thread.
>
> Currently giveup_{fpu,altivec,vsx}() does both however optimisations to
> task switching can be made if these two operations are decoupled.
> save_all() will permit the saving of registers to thread structs and leave
> threads MSR with bits enabled.
>
> This patch introduces no functional change.
> diff --git a/arch/powerpc/kernel/process.c b/arch/powerpc/kernel/process.c
> index 0955b7c..45e37c0 100644
> --- a/arch/powerpc/kernel/process.c
> +++ b/arch/powerpc/kernel/process.c
> @@ -349,6 +349,14 @@ void flush_spe_to_thread(struct task_struct *tsk)
> preempt_enable();
> }
> }
> +#else
> +/*
> + * save_all() is going to test MSR_SPE, rather than pull in all the
> + * booke definitions all the time on a books kernel just ensure it exists
> + * but acts as a nop.
> + */
> +
> +#define MSR_SPE 0
> #endif /* CONFIG_SPE */
Building corenet32/64_defconfig this gives me:
arch/powerpc/kernel/process.c:392:0: error: "MSR_SPE" redefined [-Werror]
#define MSR_SPE 0
^
In file included from ./arch/powerpc/include/asm/reg.h:18:0,
from ./arch/powerpc/include/asm/processor.h:13,
from ./arch/powerpc/include/asm/thread_info.h:33,
from include/linux/thread_info.h:54,
from include/asm-generic/preempt.h:4,
from arch/powerpc/include/generated/asm/preempt.h:1,
from include/linux/preempt.h:59,
from include/linux/spinlock.h:50,
from include/linux/seqlock.h:35,
from include/linux/time.h:5,
from include/uapi/linux/timex.h:56,
from include/linux/timex.h:56,
from include/linux/sched.h:19,
from arch/powerpc/kernel/process.c:18:
./arch/powerpc/include/asm/reg_booke.h:33:0: note: this is the location of the previous definition
#define MSR_SPE __MASK(MSR_SPE_LG)
^
cc1: all warnings being treated as errors
scripts/Makefile.build:258: recipe for target 'arch/powerpc/kernel/process.o' failed
make[1]: *** [arch/powerpc/kernel/process.o] Error 1
make[1]: *** Waiting for unfinished jobs....
Makefile:950: recipe for target 'arch/powerpc/kernel' failed
cheers
next prev parent reply other threads:[~2016-02-10 7:51 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-21 0:55 [PATCH v3 0/9] FP/VEC/VSX switching optimisations Cyril Bur
2016-01-21 0:55 ` [PATCH v3 1/9] selftests/powerpc: Test the preservation of FPU and VMX regs across syscall Cyril Bur
2016-02-10 8:56 ` [v3, " Michael Ellerman
2016-01-21 0:55 ` [PATCH v3 2/9] selftests/powerpc: Test preservation of FPU and VMX regs across preemption Cyril Bur
2016-01-21 0:55 ` [PATCH v3 3/9] selftests/powerpc: Test FPU and VMX regs in signal ucontext Cyril Bur
2016-01-21 0:55 ` [PATCH v3 4/9] powerpc: Explicitly disable math features when copying thread Cyril Bur
2016-01-25 0:04 ` Balbir Singh
2016-01-26 23:50 ` Cyril Bur
2016-01-27 12:01 ` Balbir Singh
2016-02-09 0:45 ` Cyril Bur
2016-01-21 0:55 ` [PATCH v3 5/9] powerpc: Restore FPU/VEC/VSX if previously used Cyril Bur
2016-01-21 0:55 ` [PATCH v3 6/9] powerpc: Prepare for splitting giveup_{fpu, altivec, vsx} in two Cyril Bur
2016-02-10 7:51 ` Michael Ellerman [this message]
2016-01-21 0:55 ` [PATCH v3 7/9] powerpc: Add the ability to save FPU without giving it up Cyril Bur
2016-01-21 0:55 ` [PATCH v3 8/9] powerpc: Add the ability to save Altivec " Cyril Bur
2016-01-21 0:55 ` [PATCH v3 9/9] powerpc: Add the ability to save VSX " Cyril Bur
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160210075134.07A0B140324@ozlabs.org \
--to=mpe@ellerman.id.au \
--cc=anton@samba.org \
--cc=cyrilbur@gmail.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=mikey@neuling.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).