linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Gavin Shan <gwshan@linux.vnet.ibm.com>
To: Andrew Donnellan <andrew.donnellan@au1.ibm.com>
Cc: Gavin Shan <gwshan@linux.vnet.ibm.com>, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH] powerpc/eeh: Remove duplicated check in eeh_dump_pe_log()
Date: Tue, 16 Feb 2016 10:30:26 +1100	[thread overview]
Message-ID: <20160215233026.GA16298@gwshan> (raw)
In-Reply-To: <56C14541.5000302@au1.ibm.com>

On Mon, Feb 15, 2016 at 02:25:53PM +1100, Andrew Donnellan wrote:
>On 15/02/16 10:52, Gavin Shan wrote:
>>When eeh_dump_pe_log() is called in eeh_slot_error_detail(), we
>>already have the check that the PE isn't in PCI config blocked
>>state. So we needn't the duplicated check in eeh_dump_pe_log().
>>
>>This removes the duplicated check in eeh_dump_pe_log().
>>
>>Signed-off-by: Gavin Shan <gwshan@linux.vnet.ibm.com>
>
>eeh_dump_pe_log() isn't called anywhere outside of eeh_slot_error_detail(),
>so this should have no functional change.
>
>Reviewed-by: Andrew Donnellan <andrew.donnellan@au1.ibm.com>
>

Thanks for review. Do you want to see revised patch to include your
comments?

Thanks,
Gavin

>-- 
>Andrew Donnellan              Software Engineer, OzLabs
>andrew.donnellan@au1.ibm.com  Australia Development Lab, Canberra
>+61 2 6201 8874 (work)        IBM Australia Limited

  reply	other threads:[~2016-02-15 23:31 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-14 23:52 [PATCH] powerpc/eeh: Remove duplicated check in eeh_dump_pe_log() Gavin Shan
2016-02-15  3:25 ` Andrew Donnellan
2016-02-15 23:30   ` Gavin Shan [this message]
2016-02-15 23:58     ` Andrew Donnellan
2016-02-26  0:13       ` Gavin Shan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160215233026.GA16298@gwshan \
    --to=gwshan@linux.vnet.ibm.com \
    --cc=andrew.donnellan@au1.ibm.com \
    --cc=linuxppc-dev@lists.ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).