From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ozlabs.org (ozlabs.org [103.22.144.67]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 177711A000B for ; Tue, 16 Feb 2016 14:18:25 +1100 (AEDT) In-Reply-To: <1452573620-17979-1-git-send-email-aik@ozlabs.ru> To: Alexey Kardashevskiy , linuxppc-dev@lists.ozlabs.org From: Michael Ellerman Cc: Alexey Kardashevskiy , Paul Mackerras , David Gibson Subject: Re: [RFC, kernel] powerpc/ioda: Set "read" permission when "write" is set Message-Id: <20160216031824.E5C8E140761@ozlabs.org> Date: Tue, 16 Feb 2016 14:18:24 +1100 (AEDT) List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Tue, 2016-12-01 at 04:40:20 UTC, Alexey Kardashevskiy wrote: > Quite often drivers set only "write" permission assuming that this > includes "read" permission as well and this works on plenty platforms. > However IODA2 is strict about this and produces an EEH when "read" > permission is not and reading happens. > > This adds a workaround in IODA code to always add the "read" bit when > the "write" bit is set. > > Cc: Benjamin Herrenschmidt > Signed-off-by: Alexey Kardashevskiy > Tested-by: Douglas Miller Are you planning on sending a non-RFC version of this? If so is it an urgent fix I should send upstream now? And if so should it also be CC'ed to stable? cheers