From: Paul Mackerras <paulus@ozlabs.org>
To: Balbir Singh <bsingharora@gmail.com>
Cc: Michael Ellerman <mpe@ellerman.id.au>, linuxppc-dev@lists.ozlabs.org
Subject: Re: Fix BUG_ON() reporting in real mode on powerpc
Date: Wed, 17 Feb 2016 15:56:06 +1100 [thread overview]
Message-ID: <20160217045606.GA19276@oak.ozlabs.ibm.com> (raw)
In-Reply-To: <1455684191.3089.3.camel@gmail.com>
On Wed, Feb 17, 2016 at 03:43:11PM +1100, Balbir Singh wrote:
> From: Balbir Singh <bsingharora@gmail.com>
>
> I ran into this issue while debugging an early boot problem.
> The system hit a BUG_ON() but report bug failed to print the
> line number and file name. The reason being that the system
> was running in real mode and report_bug() searches for
> addresses in the PAGE_OFFSET+ region
>
> Suggested-by: Paul Mackerras <paulus@samba.org>
> Signed-off-by: Balbir Singh <bsingharora@gmail.com>
> ---
> arch/powerpc/kernel/traps.c | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/arch/powerpc/kernel/traps.c b/arch/powerpc/kernel/traps.c
> index b6becc7..8f28120 100644
> --- a/arch/powerpc/kernel/traps.c
> +++ b/arch/powerpc/kernel/traps.c
> @@ -1148,6 +1148,7 @@ void __kprobes program_check_exception(struct pt_regs *regs)
> goto bail;
> }
> if (reason & REASON_TRAP) {
> + unsigned long bugaddr;
> /* Debugger is first in line to stop recursive faults in
> * rcu_lock, notify_die, or atomic_notifier_call_chain */
> if (debugger_bpt(regs))
> @@ -1158,8 +1159,13 @@ void __kprobes program_check_exception(struct pt_regs *regs)
> == NOTIFY_STOP)
> goto bail;
>
> + if (!(regs->msr & MSR_IR))
> + bugaddr = regs->nip + PAGE_OFFSET;
> + else
> + bugaddr = regs->nip;
It might be a little better to do this:
bugaddr = regs->nip;
if (REGION_ID(bugaddr) == 0 && !(regs->msr & MSR_IR))
bugaddr += PAGE_OFFSET;
It is possible to execute from addresses with the 0xc000... on top in
real mode, because the CPU ignores the top 4 address bits in real
mode.
Paul.
next prev parent reply other threads:[~2016-02-17 4:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-17 4:43 Fix BUG_ON() reporting in real mode on powerpc Balbir Singh
2016-02-17 4:56 ` Paul Mackerras [this message]
2016-02-17 7:16 ` Balbir Singh
2016-02-17 8:03 ` Anshuman Khandual
2016-02-17 8:23 ` Paul Mackerras
2016-02-17 15:16 ` Aneesh Kumar K.V
2016-02-18 0:25 ` Balbir Singh
2016-02-18 2:41 ` Aneesh Kumar K.V
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160217045606.GA19276@oak.ozlabs.ibm.com \
--to=paulus@ozlabs.org \
--cc=bsingharora@gmail.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).