From: Michael Ellerman <mpe@ellerman.id.au>
To: Alexey Kardashevskiy <aik@ozlabs.ru>, linuxppc-dev@lists.ozlabs.org
Cc: Alexey Kardashevskiy <aik@ozlabs.ru>,
stable@vger.kernel.org.#.4.2+, Paul Mackerras <paulus@samba.org>
Subject: Re: [kernel, v2] powerpc/ioda: Set "read" permission when "write" is set
Date: Fri, 19 Feb 2016 23:13:28 +1100 (AEDT) [thread overview]
Message-ID: <20160219121328.EA947140B04@ozlabs.org> (raw)
In-Reply-To: <1455693991-31405-1-git-send-email-aik@ozlabs.ru>
On Wed, 2016-17-02 at 07:26:31 UTC, Alexey Kardashevskiy wrote:
> Quite often drivers set only "write" permission assuming that this
> includes "read" permission as well and this works on plenty platforms.
> However IODA2 is strict about this and produces an EEH when "read"
> permission is not and reading happens.
>
> This adds a workaround in IODA code to always add the "read" bit when
> the "write" bit is set.
>
> This fixes breakage introduced in
> 10b35b2b74 powerpc/powernv: Do not set "read" flag if direction==DMA_NONE
>
> Cc: stable@vger.kernel.org # 4.2+
> Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
> Tested-by: Douglas Miller <dougmill@linux.vnet.ibm.com>
Applied to powerpc fixes, thanks.
https://git.kernel.org/powerpc/c/6ecad912a0073c768db1491c27
cheers
prev parent reply other threads:[~2016-02-19 12:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-17 7:26 [PATCH kernel v2] powerpc/ioda: Set "read" permission when "write" is set Alexey Kardashevskiy
2016-02-18 0:27 ` Benjamin Herrenschmidt
2016-02-19 12:13 ` Michael Ellerman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160219121328.EA947140B04@ozlabs.org \
--to=mpe@ellerman.id.au \
--cc=aik@ozlabs.ru \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=paulus@samba.org \
--cc=stable@vger.kernel.org.#.4.2+ \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).