From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ozlabs.org (ozlabs.org [IPv6:2401:3900:2:1::2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 1B6A21A05EA for ; Fri, 19 Feb 2016 23:13:29 +1100 (AEDT) In-Reply-To: <1455693991-31405-1-git-send-email-aik@ozlabs.ru> To: Alexey Kardashevskiy , linuxppc-dev@lists.ozlabs.org From: Michael Ellerman Cc: Alexey Kardashevskiy , stable@vger.kernel.org.#.4.2+, Paul Mackerras Subject: Re: [kernel, v2] powerpc/ioda: Set "read" permission when "write" is set Message-Id: <20160219121328.EA947140B04@ozlabs.org> Date: Fri, 19 Feb 2016 23:13:28 +1100 (AEDT) List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Wed, 2016-17-02 at 07:26:31 UTC, Alexey Kardashevskiy wrote: > Quite often drivers set only "write" permission assuming that this > includes "read" permission as well and this works on plenty platforms. > However IODA2 is strict about this and produces an EEH when "read" > permission is not and reading happens. > > This adds a workaround in IODA code to always add the "read" bit when > the "write" bit is set. > > This fixes breakage introduced in > 10b35b2b74 powerpc/powernv: Do not set "read" flag if direction==DMA_NONE > > Cc: stable@vger.kernel.org # 4.2+ > Cc: Benjamin Herrenschmidt > Signed-off-by: Alexey Kardashevskiy > Tested-by: Douglas Miller Applied to powerpc fixes, thanks. https://git.kernel.org/powerpc/c/6ecad912a0073c768db1491c27 cheers