linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
* powerpc/mm: Fix HAVE_ARCH_SOFT_DIRTY dependencies
@ 2016-02-20 17:58 Ben Hutchings
  2016-02-22  8:24 ` Michael Ellerman
  0 siblings, 1 reply; 3+ messages in thread
From: Ben Hutchings @ 2016-02-20 17:58 UTC (permalink / raw)
  To: linuxppc-dev

[-- Attachment #1: Type: text/plain, Size: 1031 bytes --]

Soft dirty bit support was only implemented for 64-bit Book3S, and
32-bit configurations currently fail to build.

Fixes: 7207f43665b8 ("powerpc/mm: Add page soft dirty tracking")
References: https://buildd.debian.org/status/fetch.php?pkg=linux&arch=powerpc&ver=4.5%7Erc4-1%7Eexp1&stamp=1455791718
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
---
--- a/arch/powerpc/Kconfig
+++ b/arch/powerpc/Kconfig
@@ -557,7 +557,7 @@ choice
 
 config PPC_4K_PAGES
 	bool "4k page size"
-	select HAVE_ARCH_SOFT_DIRTY if CHECKPOINT_RESTORE && PPC_BOOK3S
+	select HAVE_ARCH_SOFT_DIRTY if CHECKPOINT_RESTORE && PPC_BOOK3S_64
 
 config PPC_16K_PAGES
 	bool "16k page size"
@@ -566,7 +566,7 @@ config PPC_16K_PAGES
 config PPC_64K_PAGES
 	bool "64k page size"
 	depends on !PPC_FSL_BOOK3E && (44x || PPC_STD_MMU_64 || PPC_BOOK3E_64)
-	select HAVE_ARCH_SOFT_DIRTY if CHECKPOINT_RESTORE && PPC_BOOK3S
+	select HAVE_ARCH_SOFT_DIRTY if CHECKPOINT_RESTORE && PPC_BOOK3S_64
 
 config PPC_256K_PAGES
 	bool "256k page size"

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 811 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: powerpc/mm: Fix HAVE_ARCH_SOFT_DIRTY dependencies
  2016-02-20 17:58 powerpc/mm: Fix HAVE_ARCH_SOFT_DIRTY dependencies Ben Hutchings
@ 2016-02-22  8:24 ` Michael Ellerman
  2016-02-22  9:39   ` Ben Hutchings
  0 siblings, 1 reply; 3+ messages in thread
From: Michael Ellerman @ 2016-02-22  8:24 UTC (permalink / raw)
  To: Ben Hutchings, linuxppc-dev

On Sat, 2016-20-02 at 17:58:37 UTC, Ben Hutchings wrote:
> Soft dirty bit support was only implemented for 64-bit Book3S, and
> 32-bit configurations currently fail to build.
> 
> Fixes: 7207f43665b8 ("powerpc/mm: Add page soft dirty tracking")
> References: https://buildd.debian.org/status/fetch.php?pkg=linux&arch=powerpc&ver=4.5%7Erc4-1%7Eexp1&stamp=1455791718
> Signed-off-by: Ben Hutchings <ben@decadent.org.uk>

Thanks for the patch Ben.

I merged a similar but not identical patch into my fixes branch last week, and
Linus merged it over the weekend. Let me know if it isn't sufficient for you:

  https://git.kernel.org/torvalds/c/19f97c983071

cheers

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: powerpc/mm: Fix HAVE_ARCH_SOFT_DIRTY dependencies
  2016-02-22  8:24 ` Michael Ellerman
@ 2016-02-22  9:39   ` Ben Hutchings
  0 siblings, 0 replies; 3+ messages in thread
From: Ben Hutchings @ 2016-02-22  9:39 UTC (permalink / raw)
  To: Michael Ellerman, linuxppc-dev

[-- Attachment #1: Type: text/plain, Size: 962 bytes --]

On Mon, 2016-02-22 at 19:24 +1100, Michael Ellerman wrote:
> On Sat, 2016-20-02 at 17:58:37 UTC, Ben Hutchings wrote:
> > Soft dirty bit support was only implemented for 64-bit Book3S, and
> > 32-bit configurations currently fail to build.
> > 
> > Fixes: 7207f43665b8 ("powerpc/mm: Add page soft dirty tracking")
> > References: https://buildd.debian.org/status/fetch.php?pkg=linux&arch=powerpc&ver=4.5%7Erc4-1%7Eexp1&stamp=1455791718
> > Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
> 
> Thanks for the patch Ben.
> 
> I merged a similar but not identical patch into my fixes branch last week, and
> Linus merged it over the weekend. Let me know if it isn't sufficient for you:
> 
>   https://git.kernel.org/torvalds/c/19f97c983071

Yes that works, thanks.

Ben.

-- 
Ben Hutchings
The generation of random numbers is too important to be left to chance.
                                                            - Robert Coveyou

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 811 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2016-02-22  9:39 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-02-20 17:58 powerpc/mm: Fix HAVE_ARCH_SOFT_DIRTY dependencies Ben Hutchings
2016-02-22  8:24 ` Michael Ellerman
2016-02-22  9:39   ` Ben Hutchings

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).