From: Sam Bobroff <sam.bobroff@au1.ibm.com>
To: Scott Wood <oss@buserror.net>
Cc: linuxppc-dev@lists.ozlabs.org, michaele@au1.ibm.com
Subject: Re: [PATCH 1/1] powerpc: Detect broken or mismatched toolchains
Date: Tue, 23 Feb 2016 15:59:07 +1100 [thread overview]
Message-ID: <20160223045907.GA28294@tungsten.ozlabs.ibm.com> (raw)
In-Reply-To: <1456193101.2463.133.camel@buserror.net>
On Mon, Feb 22, 2016 at 08:05:01PM -0600, Scott Wood wrote:
> On Mon, 2016-02-22 at 16:13 +1100, Sam Bobroff wrote:
> > It can currently be difficult to diagnose a build that fails due to
> > the compiler, linker or other parts of the toolchain being unable to
> > build binaries of the type required by the kernel config. For example
> > using a little endian toolchain to build a big endian kernel may
> > produce:
> >
> > as: unrecognized option '-maltivec'
> >
> > This patch adds a basic compile test and error message to
> > arch/powerpc/Makefile so that the above error becomes:
> >
> > *** Sorry, your toolchain seems to be broken or incorrect. ***
> > Make sure it supports your kernel configuration (ppc64).
> >
> > Signed-off-by: Sam Bobroff <sam.bobroff@au1.ibm.com>
> > ---
>
> How is this more useful than getting to actually see the way in which the
> toolchain (or the CFLAGS) is broken?
My reasoning was that it would be better because it happens at the start of the
build, rather than (possibly) a long way into it, and it indicates that the
problem is the toolchain setup (or config) itself rather than the file it's
trying to compile or link.
But I agree completely with what you're saying. I'll try re-working it in a way
that shows the command that fails and it's output.
Cheers,
Sam.
prev parent reply other threads:[~2016-02-23 5:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-22 5:13 [PATCH 1/1] powerpc: Detect broken or mismatched toolchains Sam Bobroff
2016-02-23 2:05 ` Scott Wood
2016-02-23 4:59 ` Sam Bobroff [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160223045907.GA28294@tungsten.ozlabs.ibm.com \
--to=sam.bobroff@au1.ibm.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=michaele@au1.ibm.com \
--cc=oss@buserror.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).