From: Michael Ellerman <mpe@ellerman.id.au>
To: Gavin Shan <gwshan@linux.vnet.ibm.com>, linuxppc-dev@lists.ozlabs.org
Cc: Gavin Shan <gwshan@linux.vnet.ibm.com>
Subject: Re: powerpc/eeh: Fix partial hotplug criterion
Date: Thu, 25 Feb 2016 01:35:17 +1100 (AEDT) [thread overview]
Message-ID: <20160224143517.64011140BFD@ozlabs.org> (raw)
In-Reply-To: <1455253387-478-1-git-send-email-gwshan@linux.vnet.ibm.com>
On Fri, 2016-12-02 at 05:03:05 UTC, Gavin Shan wrote:
> During error recovery, the device could be removed as part of the
> partial hotplug. The criterion used to come with partial hotplug
> is: if the device driver provides error_detected(), slot_reset()
> and resume() callbacks, it's immune from hotplug. Otherwise,
> it's going to experience partial hotplug during EEH recovery. But
> the criterion isn't correct enough: mlx4_core driver for Mellanox
> adapters provides error_detected(), slot_reset() callbacks, but
> resume() isn't there. Those Mellanox adapters won't be to involved
> in the partial hotplug.
>
> This fixes the criterion to a practical one: adpater with driver
> that provides error_detected(), slot_reset() will be immune from
> partial hotplug. resume() isn't mandatory.
>
> Fixes: f2da4ccf ("powerpc/eeh: More relaxed hotplug criterion")
> Cc: stable@vger.kernel.org #v4.4+
> Signed-off-by: Gavin Shan <gwshan@linux.vnet.ibm.com>
Applied to powerpc fixes, thanks.
https://git.kernel.org/powerpc/c/f6bf0fa14cf848ae770e0b7842
cheers
prev parent reply other threads:[~2016-02-24 14:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-12 5:03 [PATCH] powerpc/eeh: Fix partial hotplug criterion Gavin Shan
2016-02-24 14:35 ` Michael Ellerman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160224143517.64011140BFD@ozlabs.org \
--to=mpe@ellerman.id.au \
--cc=gwshan@linux.vnet.ibm.com \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).