From: Michael Ellerman <mpe@ellerman.id.au>
To: Anshuman Khandual <khandual@linux.vnet.ibm.com>,
linuxppc-dev@lists.ozlabs.org
Cc: aneesh.kumar@linux.vnet.ibm.com
Subject: Re: powerpc/lpar: Don't crash on H_PROTECT errors
Date: Tue, 1 Mar 2016 10:01:41 +1100 (AEDT) [thread overview]
Message-ID: <20160229230141.A8B4F140B99@ozlabs.org> (raw)
In-Reply-To: <1456746752-9298-1-git-send-email-khandual@linux.vnet.ibm.com>
On Mon, 2016-29-02 at 11:52:32 UTC, Anshuman Khandual wrote:
> There are certain condition in which H_PROTECT can return error code
> other than H_NOT_FOUND and H_SUCCESS. One such being an attempt to
> update an hpte owned by adjunct partition. Return 0 in that case so
> that user space will retry the access. In adjunct case this mean we
> will not make much progress in the user space. But atleast we get a
> chance to kill the task and avoid taking down the entire box.
Why is it OK to do nothing and return 0?
The function's contract is that it either does the update or returns -1, you
can't change that without auditing all callers - and describing that in the
change log.
cheers
next prev parent reply other threads:[~2016-02-29 23:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-29 11:52 [PATCH] powerpc/lpar: Don't crash on H_PROTECT errors Anshuman Khandual
2016-02-29 16:50 ` Tyrel Datwyler
2016-03-01 4:34 ` Anshuman Khandual
2016-03-01 5:27 ` Aneesh Kumar K.V
2016-03-01 5:46 ` Anshuman Khandual
2016-02-29 23:01 ` Michael Ellerman [this message]
2016-03-01 5:27 ` Anshuman Khandual
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160229230141.A8B4F140B99@ozlabs.org \
--to=mpe@ellerman.id.au \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=khandual@linux.vnet.ibm.com \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).