From: Michael Ellerman <mpe@ellerman.id.au>
To: Luis Henriques <luis.henriques@canonical.com>,
Geoff Levand <geoff@infradead.org>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>
Cc: Joe Perches <joe@perches.com>,
linuxppc-dev@lists.ozlabs.org,
Geert Uytterhoeven <geert@linux-m68k.org>,
linux-kernel@vger.kernel.org
Subject: Re: [v2, 1/4] powerpc/ps3: gelic_udbg: use struct ethhdr from <linux/if_ether.h>
Date: Wed, 2 Mar 2016 09:21:19 +1100 (AEDT) [thread overview]
Message-ID: <20160301222119.4D99E140273@ozlabs.org> (raw)
In-Reply-To: <1454970427-23017-2-git-send-email-luis.henriques@canonical.com>
On Mon, 2016-08-02 at 22:27:04 UTC, Luis Henriques wrote:
> Instead of defining a local version of struct ethhdr use the standard
> definition from <linux/if_ether.h>.
>
> The fields in the <linux/if_ether.h> definition have different names:
> - dest -> h_dest
> - src -> h_source
> - type -> h_proto
>
> While there, use a few other standard functions/macros:
> - eth_broadcast_addr (instead of a memset)
> - ETH_ALEN
> - ETH_P_8021Q
>
> Signed-off-by: Luis Henriques <luis.henriques@canonical.com>
Series applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/497abcf6afe2d85f047fbf1373
cheers
next prev parent reply other threads:[~2016-03-01 22:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-08 22:27 [PATCH v2 0/4] powerpc/ps3: gelic_udbg: drop local versions of network data structs Luis Henriques
2016-02-08 22:27 ` [PATCH v2 1/4] powerpc/ps3: gelic_udbg: use struct ethhdr from <linux/if_ether.h> Luis Henriques
2016-03-01 22:21 ` Michael Ellerman [this message]
2016-02-08 22:27 ` [PATCH v2 2/4] powerpc/ps3: gelic_udbg: use struct vlan_hdr from <linux/if_vlan.h> Luis Henriques
2016-02-08 22:27 ` [PATCH v2 3/4] powerpc/ps3: gelic_udbg: use struct iphdr from <linux/ip.h> Luis Henriques
2016-02-08 22:27 ` [PATCH v2 4/4] powerpc/ps3: gelic_udbg: use struct udphdr from <linux/udp.h> Luis Henriques
2016-02-09 2:54 ` [PATCH v2 0/4] powerpc/ps3: gelic_udbg: drop local versions of network data structs Michael Ellerman
2016-02-11 23:20 ` Geoff Levand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160301222119.4D99E140273@ozlabs.org \
--to=mpe@ellerman.id.au \
--cc=benh@kernel.crashing.org \
--cc=geert@linux-m68k.org \
--cc=geoff@infradead.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=luis.henriques@canonical.com \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).