From: David Gibson <david@gibson.dropbear.id.au>
To: Michael Ellerman <mpe@ellerman.id.au>
Cc: paulus@samba.org, benh@kernel.crashing.org,
linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [4/4] powerpc/mm: Split hash page table sizing heuristic into a helper
Date: Wed, 2 Mar 2016 10:26:01 +1100 [thread overview]
Message-ID: <20160301232601.GL5427@voom.redhat.com> (raw)
In-Reply-To: <20160301222119.D4717140326@ozlabs.org>
[-- Attachment #1: Type: text/plain, Size: 1406 bytes --]
On Wed, Mar 02, 2016 at 09:21:19AM +1100, Michael Ellerman wrote:
> On Tue, 2016-09-02 at 03:32:43 UTC, David Gibson wrote:
> > htab_get_table_size() either retrieve the size of the hash page table (HPT)
> > from the device tree - if the HPT size is determined by firmware - or
> > uses a heuristic to determine a good size based on RAM size if the kernel
> > is responsible for allocating the HPT.
> >
> > To support a PAPR extension allowing resizing of the HPT, we're going to
> > want the memory size -> HPT size logic elsewhere, so split it out into a
> > helper function.
> >
> > Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
> > Reviewed-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
>
> Applied to powerpc next, thanks.
>
> https://git.kernel.org/powerpc/c/5c3c7ede2bdcb85fa2fd51c814
>
> I reworded one comment a little, from:
>
> /* 2^11 PTEGS / 2^18 bytes is the minimum htab size permitted
> * by the architecture */
>
> to:
> /*
> * 2^11 PTEGS of 128 bytes each, ie. 2^18 bytes is the minimum htab
> * size permitted by the architecture.
> */
>
> To avoid any confusion about the "/" referring to division.
Good call, thanks.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
prev parent reply other threads:[~2016-03-01 23:25 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-09 3:32 [PATCH 0/4] powerpc/mm: Cleanups to hotplug memory path David Gibson
2016-02-09 3:32 ` [PATCH 1/4] powerpc/mm: Clean up error handling for htab_remove_mapping David Gibson
2016-02-10 8:56 ` Aneesh Kumar K.V
2016-03-01 22:21 ` [1/4] " Michael Ellerman
2016-02-09 3:32 ` [PATCH 2/4] powerpc/mm: Handle removing maybe-present bolted HPTEs David Gibson
2016-02-10 8:58 ` Aneesh Kumar K.V
2016-03-01 22:21 ` [2/4] " Michael Ellerman
2016-02-09 3:32 ` [PATCH 3/4] powerpc/mm: Clean up memory hotplug failure paths David Gibson
2016-02-10 9:00 ` Aneesh Kumar K.V
2016-03-01 1:59 ` [3/4] " Michael Ellerman
2016-03-01 2:27 ` David Gibson
2016-03-01 22:21 ` Michael Ellerman
2016-02-09 3:32 ` [PATCH 4/4] powerpc/mm: Split hash page table sizing heuristic into a helper David Gibson
2016-02-10 9:01 ` Aneesh Kumar K.V
2016-03-01 22:21 ` [4/4] " Michael Ellerman
2016-03-01 23:26 ` David Gibson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160301232601.GL5427@voom.redhat.com \
--to=david@gibson.dropbear.id.au \
--cc=benh@kernel.crashing.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).