From: Paul Mackerras <paulus@ozlabs.org>
To: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
Cc: benh@kernel.crashing.org, mpe@ellerman.id.au,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [RFC PATCH 1/2] powerpc/mm: Update prot_none implementation using _PAGE_READ
Date: Wed, 2 Mar 2016 11:38:26 +1100 [thread overview]
Message-ID: <20160302003826.GA3160@oak.ozlabs.ibm.com> (raw)
In-Reply-To: <1456456850-2679-1-git-send-email-aneesh.kumar@linux.vnet.ibm.com>
On Fri, Feb 26, 2016 at 08:50:49AM +0530, Aneesh Kumar K.V wrote:
> Now that we have _PAGE_READ use that to implement prot none. With this
> prot_none is _PAGE_PRESENT with none of the access bits set. While
> hashing we map that to PP bit 00.
>
> With this implementation, we will now take a prot fault for prot none
> ptes, whereas before, we never inserted such a pte to hash. Hence we
> always got nohpte fault before.
>
> This is in preparation to remove _PAGE_USER from book3s 64
Mostly looks good, but I have a comment:
> @@ -176,10 +177,12 @@
> #define PAGE_SHARED __pgprot(_PAGE_BASE | _PAGE_USER | _PAGE_RW)
> #define PAGE_SHARED_X __pgprot(_PAGE_BASE | _PAGE_USER | _PAGE_RW | \
> _PAGE_EXEC)
Don't we need _PAGE_READ in PAGE_SHARED[_X] now?
Paul.
next prev parent reply other threads:[~2016-03-02 1:08 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-26 3:20 [RFC PATCH 1/2] powerpc/mm: Update prot_none implementation using _PAGE_READ Aneesh Kumar K.V
2016-02-26 3:20 ` [RFC PATCH 2/2] powerpc/mm: Replace _PAGE_USER with _PAGE_PRIV Aneesh Kumar K.V
2016-02-29 2:36 ` Benjamin Herrenschmidt
2016-02-29 7:49 ` Aneesh Kumar K.V
2016-03-02 1:07 ` Paul Mackerras
2016-03-05 8:29 ` Aneesh Kumar K.V
2016-03-05 10:41 ` Paul Mackerras
2016-03-02 0:38 ` Paul Mackerras [this message]
2016-03-02 1:39 ` [RFC PATCH 1/2] powerpc/mm: Update prot_none implementation using _PAGE_READ Paul Mackerras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160302003826.GA3160@oak.ozlabs.ibm.com \
--to=paulus@ozlabs.org \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=benh@kernel.crashing.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).