From: Michael Ellerman <mpe@ellerman.id.au>
To: Frederic Barrat <fbarrat@linux.vnet.ibm.com>,
imunsie@au1.ibm.com, michael.neuling@au1.ibm.com,
manoj@linux.vnet.ibm.com, mrochs@linux.vnet.ibm.com,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [v6,20/20] cxl: Remove cxl_get_phys_dev() kernel API
Date: Wed, 9 Mar 2016 22:09:45 +1100 (AEDT) [thread overview]
Message-ID: <20160309110945.44E2E140328@ozlabs.org> (raw)
In-Reply-To: <1457090804-9719-21-git-send-email-fbarrat@linux.vnet.ibm.com>
On Fri, 2016-04-03 at 11:26:44 UTC, Frederic Barrat wrote:
> The cxl_get_phys_dev() API returns a struct device pointer which could
> belong to either a struct pci_dev (bare-metal) or platform_device
> (powerVM). To avoid potential problems in drivers, remove that API. It
> was introduced to allow drivers to read the VPD of the adapter, but
> the cxl driver now provides the cxl_pci_read_adapter_vpd() API for
> that purpose.
>
> diff --git a/drivers/misc/cxl/api.c b/drivers/misc/cxl/api.c
> index 75ec2f9..2107c94 100644
> --- a/drivers/misc/cxl/api.c
> +++ b/drivers/misc/cxl/api.c
> @@ -76,7 +76,6 @@ struct device *cxl_get_phys_dev(struct pci_dev *dev)
>
> return afu->adapter->dev.parent;
> }
> -EXPORT_SYMBOL_GPL(cxl_get_phys_dev);
This appears to make cxl_get_phys_dev() completely unused, doesn't it?
If so, please send me a follow-up patch to remove it entirely.
cheers
next prev parent reply other threads:[~2016-03-09 11:09 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-04 11:26 [PATCH v6 00/20] cxl: Add support for powerVM guest Frederic Barrat
2016-03-04 11:26 ` [PATCH v6 01/20] cxl: Move common code away from bare-metal-specific files Frederic Barrat
2016-03-10 2:03 ` [v6, " Michael Ellerman
2016-03-04 11:26 ` [PATCH v6 02/20] cxl: Move bare-metal specific code to specialized files Frederic Barrat
2016-03-04 11:26 ` [PATCH v6 03/20] cxl: Define process problem state area at attach time only Frederic Barrat
2016-03-04 11:26 ` [PATCH v6 04/20] cxl: Introduce implementation-specific API Frederic Barrat
2016-03-04 11:26 ` [PATCH v6 05/20] cxl: Rename some bare-metal specific functions Frederic Barrat
2016-03-04 11:26 ` [PATCH v6 06/20] cxl: Isolate a few bare-metal-specific calls Frederic Barrat
2016-03-04 11:26 ` [PATCH v6 07/20] cxl: Update cxl_irq() prototype Frederic Barrat
2016-03-04 11:26 ` [PATCH v6 08/20] cxl: IRQ allocation for guests Frederic Barrat
2016-03-04 11:26 ` [PATCH v6 09/20] powerpc: New possible return value from hcall Frederic Barrat
2016-03-04 11:26 ` [PATCH v6 10/20] cxl: New hcalls to support cxl adapters Frederic Barrat
2016-03-04 11:26 ` [PATCH v6 11/20] cxl: Separate bare-metal fields in adapter and AFU data structures Frederic Barrat
2016-03-04 11:26 ` [PATCH v6 12/20] cxl: Add guest-specific code Frederic Barrat
2016-03-09 5:55 ` [v6,12/20] " Michael Ellerman
2016-03-09 9:14 ` Frederic Barrat
2016-03-09 10:31 ` Michael Ellerman
2016-03-09 12:42 ` Michael Ellerman
2016-03-09 12:57 ` Michael Ellerman
2016-03-09 14:20 ` Frederic Barrat
2016-03-04 11:26 ` [PATCH v6 13/20] cxl: sysfs support for guests Frederic Barrat
2016-03-07 5:21 ` Ian Munsie
2016-03-04 11:26 ` [PATCH v6 14/20] cxl: Support to flash a new image on the adapter from a guest Frederic Barrat
2016-03-07 5:23 ` Ian Munsie
2016-03-04 11:26 ` [PATCH v6 15/20] cxl: Parse device tree and create cxl device(s) at boot Frederic Barrat
2016-03-04 11:26 ` [PATCH v6 16/20] cxl: Support the cxl kernel API from a guest Frederic Barrat
2016-03-04 11:26 ` [PATCH v6 17/20] cxl: Adapter failure handling Frederic Barrat
2016-03-04 11:26 ` [PATCH v6 18/20] cxl: Add tracepoints around the cxl hcall Frederic Barrat
2016-03-04 11:26 ` [PATCH v6 19/20] cxlflash: Use new cxl_pci_read_adapter_vpd() API Frederic Barrat
2016-03-04 14:41 ` Uma Krishnan
2016-03-04 16:32 ` Matthew R. Ochs
2016-03-04 17:41 ` Manoj Kumar
2016-03-04 11:26 ` [PATCH v6 20/20] cxl: Remove cxl_get_phys_dev() kernel API Frederic Barrat
2016-03-07 5:25 ` Ian Munsie
2016-03-09 11:09 ` Michael Ellerman [this message]
2016-03-09 11:35 ` [v6,20/20] " Frederic Barrat
2016-03-07 5:28 ` [PATCH v6 00/20] cxl: Add support for powerVM guest Ian Munsie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160309110945.44E2E140328@ozlabs.org \
--to=mpe@ellerman.id.au \
--cc=fbarrat@linux.vnet.ibm.com \
--cc=imunsie@au1.ibm.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=manoj@linux.vnet.ibm.com \
--cc=michael.neuling@au1.ibm.com \
--cc=mrochs@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).