From: Petr Mladek <pmladek@suse.com>
To: Torsten Duwe <duwe@lst.de>
Cc: Balbir Singh <bsingharora@gmail.com>,
Jiri Kosina <jikos@kernel.org>,
Michael Ellerman <mpe@ellerman.id.au>,
linuxppc-dev@ozlabs.org, jeyu@redhat.com,
linux-kernel@vger.kernel.org, rostedt@goodmis.org,
kamalesh@linux.vnet.ibm.com, live-patching@vger.kernel.org,
mbenes@suse.cz
Subject: Re: [v3,1/8] powerpc: Create a helper for getting the kernel toc value
Date: Fri, 18 Mar 2016 11:52:49 +0100 [thread overview]
Message-ID: <20160318105249.GO22171@pathway.suse.cz> (raw)
In-Reply-To: <20160317155928.GB32575@lst.de>
On Thu 2016-03-17 16:59:28, Torsten Duwe wrote:
> On Thu, Mar 17, 2016 at 10:58:42AM +1100, Balbir Singh wrote:
> >
> > To be honest I think my v6 works well, but I don't have complete confidence
> > due to the lack of proper testing. livepatch samples plus some others I wrote
> > and I one Petr wrote all work (calling patched from within patched),
>
> I have outlined a failure scenario for you as a reply to v6 ;)
>
> Question to all: would it be feasible to limit the size of a single module's
> .text + TOC to let's say 8MB, and place modules at 10MB granularity? Then it
> would be unambiguous: exactly iff the high 40 bits of (TOC-LR) are zero, both
> belong to the same module.
We need to be careful about any limit. I did a quick check of the size
of modules on my system and there is one 13MB big:
13737713 ./3.12.44-52.18-default/extra/fglrx.ko
Another problem is security. If we align the modules too much, it
might make the life easier for the bad guys. Well, we do not need
to put the modules at the very beginning of the assigned slot.
Best Regards,
Petr
prev parent reply other threads:[~2016-03-18 10:52 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-03 4:26 [PATCH v3 1/8] powerpc: Create a helper for getting the kernel toc value Michael Ellerman
2016-03-03 4:26 ` [PATCH v3 2/8] powerpc/module: Only try to generate the ftrace_caller() stub once Michael Ellerman
2016-03-03 4:26 ` [PATCH v3 3/8] powerpc/module: Mark module stubs with a magic value Michael Ellerman
2016-03-03 4:26 ` [PATCH v3 4/8] powerpc/module: Create a special stub for ftrace_caller() Michael Ellerman
2016-03-03 4:26 ` [PATCH v3 5/8] powerpc/ftrace: Use generic ftrace_modify_all_code() Michael Ellerman
2016-03-03 4:26 ` [PATCH v3 6/8] powerpc/ftrace: Use $(CC_FLAGS_FTRACE) when disabling ftrace Michael Ellerman
2016-03-03 4:26 ` [PATCH v3 7/8] powerpc/ftrace: Add support for -mprofile-kernel ftrace ABI Michael Ellerman
2016-03-04 1:57 ` Balbir Singh
2016-03-03 4:27 ` [PATCH v3 8/8] powerpc/ftrace: Add Kconfig & Make glue for mprofile-kernel Michael Ellerman
2016-03-03 6:47 ` [PATCH v3 1/8] powerpc: Create a helper for getting the kernel toc value Kamalesh Babulal
2016-03-04 1:56 ` Balbir Singh
2016-03-14 9:25 ` [v3, " Michael Ellerman
2016-03-15 1:27 ` [v3,1/8] " Jiri Kosina
2016-03-16 10:23 ` Michael Ellerman
2016-03-16 14:58 ` Torsten Duwe
2016-03-16 23:56 ` Balbir Singh
2016-03-16 23:58 ` Balbir Singh
2016-03-17 15:59 ` Torsten Duwe
2016-03-18 10:52 ` Petr Mladek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160318105249.GO22171@pathway.suse.cz \
--to=pmladek@suse.com \
--cc=bsingharora@gmail.com \
--cc=duwe@lst.de \
--cc=jeyu@redhat.com \
--cc=jikos@kernel.org \
--cc=kamalesh@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=live-patching@vger.kernel.org \
--cc=mbenes@suse.cz \
--cc=mpe@ellerman.id.au \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).