From: Viresh Kumar <viresh.kumar@linaro.org>
To: Paul Gortmaker <paul.gortmaker@windriver.com>
Cc: linux-kernel@vger.kernel.org,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Christian Krafft <krafft@de.ibm.com>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>,
Michael Ellerman <mpe@ellerman.id.au>,
linuxppc-dev@lists.ozlabs.org, linux-pm@vger.kernel.org
Subject: Re: [PATCH 3/3] drivers/cpufreq: make ppc_cbe_cpufreq_pmi driver explicitly non-modular
Date: Mon, 28 Mar 2016 08:03:14 +0530 [thread overview]
Message-ID: <20160328023314.GA28406@vireshk-i7> (raw)
In-Reply-To: <1459116497-19991-4-git-send-email-paul.gortmaker@windriver.com>
On 27-03-16, 18:08, Paul Gortmaker wrote:
> The Kconfig for this driver is currently:
>
> config CPU_FREQ_CBE_PMI
> bool "CBE frequency scaling using PMI interface"
>
> ...meaning that it currently is not being built as a module by
> anyone. Lets remove the modular and unused code here, so that
> when reading the driver there is no doubt it is builtin-only.
>
> Since module_init translates to device_initcall in the non-modular
> case, the init ordering remains unchanged with this commit.
>
> We also delete the MODULE_LICENSE tag etc. since all that information
> is already contained at the top of the file in the comments.
>
> Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>
> Cc: Viresh Kumar <viresh.kumar@linaro.org>
> Cc: Christian Krafft <krafft@de.ibm.com>
> Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> Cc: Paul Mackerras <paulus@samba.org>
> Cc: Michael Ellerman <mpe@ellerman.id.au>
> Cc: linuxppc-dev@lists.ozlabs.org
> Cc: linux-pm@vger.kernel.org
> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
> ---
> drivers/cpufreq/ppc_cbe_cpufreq_pmi.c | 15 ++-------------
> 1 file changed, 2 insertions(+), 13 deletions(-)
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
--
viresh
next prev parent reply other threads:[~2016-03-28 2:33 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-27 22:08 [PATCH 0/3] powerpc: remove unused modular code from non-modular drivers Paul Gortmaker
2016-03-27 22:08 ` [PATCH 1/3] powerpc: make cell/spu_base.c explicitly non-modular Paul Gortmaker
2016-04-11 12:35 ` [1/3] " Michael Ellerman
2016-03-27 22:08 ` [PATCH 2/3] powerpc: make kernel/nvram_64.c " Paul Gortmaker
2016-03-28 14:22 ` Nathan Fontenot
2016-04-11 12:35 ` [2/3] " Michael Ellerman
2016-03-27 22:08 ` [PATCH 3/3] drivers/cpufreq: make ppc_cbe_cpufreq_pmi driver " Paul Gortmaker
2016-03-28 2:33 ` Viresh Kumar [this message]
2016-04-11 12:35 ` [3/3] " Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160328023314.GA28406@vireshk-i7 \
--to=viresh.kumar@linaro.org \
--cc=benh@kernel.crashing.org \
--cc=krafft@de.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=paul.gortmaker@windriver.com \
--cc=paulus@samba.org \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).