From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3qYYKP5ZbKzDq72 for ; Mon, 28 Mar 2016 23:35:37 +1100 (AEDT) Date: Mon, 28 Mar 2016 09:35:31 -0300 From: Arnaldo Carvalho de Melo To: Jiri Olsa Cc: Sukadev Bhattiprolu , Ingo Molnar , Michael Ellerman , linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org Subject: Re: [PATCH 1/1] perf tools: Fix build break on powerpc Message-ID: <20160328123531.GB8706@kernel.org> References: <20160326180146.GA32441@us.ibm.com> <20160327111903.GC4015@krava.sund.root.ku.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 In-Reply-To: <20160327111903.GC4015@krava.sund.root.ku.dk> List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Em Sun, Mar 27, 2016 at 01:19:03PM +0200, Jiri Olsa escreveu: > On Sat, Mar 26, 2016 at 11:01:47AM -0700, Sukadev Bhattiprolu wrote: > > From 502e8236082412db1d33abfad95aaf14b539502e Mon Sep 17 00:00:00 2001 > > From: Sukadev Bhattiprolu > > Date: Sat, 26 Mar 2016 17:31:39 -0400 > > Subject: [PATCH 1/1] perf tools: Fix build break on powerpc > > MIME-Version: 1.0 > > Content-Type: text/plain; charset=UTF-8 > > Content-Transfer-Encoding: 8bit > > > > 'Commit 531d2410635c ("perf tools: Do not include stringify.h from the > > kernel sources")' seems to have accidentially removed the inclusion of > > "util/header.h" from "arch/powerpc/util/header.c". > > > > "util/header.h" provides the prototype for get_cpuid() and is needed to > > build perf on Powerpc. > > > > arch/powerpc/util/header.c:17:1: error: no previous prototype for > > ‘get_cpuid’ [-Werror=missing-prototypes] > > > > Reported-by: Michael Ellerman > > Signed-off-by: Sukadev Bhattiprolu > > --- > > tools/perf/arch/powerpc/util/header.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/tools/perf/arch/powerpc/util/header.c b/tools/perf/arch/powerpc/util/header.c > > index 6138bde..5111e34 100644 > > --- a/tools/perf/arch/powerpc/util/header.c > > +++ b/tools/perf/arch/powerpc/util/header.c > > @@ -4,6 +4,7 @@ > > #include > > #include > > #include > > +#include "../../util/header.h" > > you could use just "header.h" right? Like this? I'm trying to find a way to do ppc cross builds, one more thing to have in the build-tests... commit 150da025b7f135450ca833fb80d54d59f0ddf185 Author: Sukadev Bhattiprolu Date: Mon Mar 28 09:31:41 2016 -0300 perf tools: Fix build break on powerpc Commit 531d2410635c ("perf tools: Do not include stringify.h from the kernel sources") seems to have accidentially removed the inclusion of "util/header.h" from "arch/powerpc/util/header.c". "util/header.h" provides the prototype for get_cpuid() and is needed to build perf on Powerpc: arch/powerpc/util/header.c:17:1: error: no previous prototype for ‘get_cpuid’ [-Werror=missing-prototypes] Reported-by: Michael Ellerman Fixes: 531d2410635c ("perf tools: Do not include stringify.h from the kernel sources") Signed-off-by: Sukadev Bhattiprolu Signed-off-by: Arnaldo Carvalho de Melo diff --git a/tools/perf/arch/powerpc/util/header.c b/tools/perf/arch/powerpc/util/header.c index 6138bdef6e63..6de1a93241ae 100644 --- a/tools/perf/arch/powerpc/util/header.c +++ b/tools/perf/arch/powerpc/util/header.c @@ -4,6 +4,7 @@ #include #include #include +#include "header.h" #define mfspr(rn) ({unsigned long rval; \ asm volatile("mfspr %0," __stringify(rn) \