From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf0-x22f.google.com (mail-pf0-x22f.google.com [IPv6:2607:f8b0:400e:c00::22f]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3qgCxY6Y11zDq5d for ; Thu, 7 Apr 2016 03:53:05 +1000 (AEST) Received: by mail-pf0-x22f.google.com with SMTP id c20so38164925pfc.1 for ; Wed, 06 Apr 2016 10:53:05 -0700 (PDT) Date: Wed, 6 Apr 2016 10:52:54 -0700 From: Brian Norris To: Li Yang Cc: Scott Wood , Raghav Dogra , linux-mtd@lists.infradead.org, linuxppc-dev , Prabhakar Kushwaha , Raghav Dogra , Jaiprakash Singh , Boris Brezillon Subject: Re: [PATCH][v3] mtd/ifc: Add support for IFC controller version 2.0 Message-ID: <20160406175254.GC5243@localhost> References: <1455708258-3831-1-git-send-email-raghav.dogra@nxp.com> <1455840434.2463.97.camel@buserror.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Hi, On Wed, Mar 30, 2016 at 03:43:40PM -0500, Li Yang wrote: > Hi Brian, > > Could you help to review and pull in this patch and the Kconfig update > after this patch(https://patchwork.ozlabs.org/patch/557389/)? It It's probably best for Boris to apply this now. > stated a dependency in the notes, but actually it should be applied > cleanly without that patch. These patches are critical to make NAND > mtd feature work for our new chips. > > Regards, > Leo > > On Thu, Feb 18, 2016 at 6:07 PM, Scott Wood wrote: > > On Thu, 2016-02-18 at 15:18 -0600, Leo Li wrote: > >> On Wed, Feb 17, 2016 at 5:24 AM, Raghav Dogra wrote: > >> > The new IFC controller version 2.0 has a different memory map page. > >> > Upto IFC 1.4 PAGE size is 4 KB and from IFC2.0 PAGE size is 64KB. > >> > This patch segregates the IFC global and runtime registers to appropriate > >> > PAGE sizes. > >> > > >> > Signed-off-by: Jaiprakash Singh > >> > Signed-off-by: Raghav Dogra > >> > Acked-by: Li Yang > >> > Signed-off-by: Raghav Dogra > >> > --- > >> > Changes for v3: not dependent on > >> > "drivers/memory: Add deep sleep support for IFC" patch > >> > > >> > Changes for v2: rebased to resolve conflicts > >> > Applicable to git://git.infradead.org/l2-mtd.git > >> > > >> > This patch is dependent on "drivers/memory: Add deep sleep support for > >> > IFC" > >> > https://patchwork.ozlabs.org/patch/582762/ > >> > which is also applicable to git://git.infradead.org/l2-mtd.git For the patch: Acked-by: Brian Norris > >> This patch seems to be in good shape, but the dependency is still > >> having quite some feedback to be addressed. Depending on it will > >> greatly delay the time that this critical patch for LS2 to be merged. > >> Could you remove the dependency like Scott already suggested? > > > > According to the changelog the dependency has been removed (it would have been > > clearer to remove this comment as well...). > > > > -Scott > > > > > > -- > - Leo