From: Viresh Kumar <viresh.kumar@linaro.org>
To: Akshay Adiga <akshay.adiga@linux.vnet.ibm.com>
Cc: rjw@rjwysocki.net, linux-pm@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org, ego@linux.vnet.ibm.com
Subject: Re: [PATCH 2/2] cpufreq: powernv: Ramp-down global pstate slower than local-pstate
Date: Thu, 14 Apr 2016 07:49:27 +0530 [thread overview]
Message-ID: <20160414021927.GK19433@vireshk-i7> (raw)
In-Reply-To: <570E889F.2010401@linux.vnet.ibm.com>
On 13-04-16, 23:27, Akshay Adiga wrote:
> On 04/13/2016 10:33 AM, Viresh Kumar wrote:
> >>+void gpstate_timer_handler(unsigned long data)
> >>+{
> >>+ struct cpufreq_policy *policy = (struct cpufreq_policy *) data;
> >no need to cast.
>
> May be i need a cast here, because data is unsigned long ( unlike other places where its void *).
> On building without cast, it throws me a warning.
My bad, yeah :(
> >>+ if (freq_data.gpstate_id != freq_data.pstate_id)
> >>+ ret = queue_gpstate_timer(gpstates);
> >ret not used.
>
> Should i make it void instead of returning int?, as i cannot do much even if it fails, except for notifying.
Sure.
--
viresh
next prev parent reply other threads:[~2016-04-14 2:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-12 18:06 [PATCH 0/2] cpufreq: powernv: Ramp-down global pstate slower than local-pstate Akshay Adiga
2016-04-12 18:06 ` [PATCH 1/2] cpufreq: powernv: Remove flag use-case of policy->driver_data Akshay Adiga
2016-04-12 18:06 ` [PATCH 2/2] cpufreq: powernv: Ramp-down global pstate slower than local-pstate Akshay Adiga
2016-04-13 5:03 ` Viresh Kumar
2016-04-13 17:57 ` Akshay Adiga
2016-04-14 2:19 ` Viresh Kumar [this message]
2016-04-14 5:40 ` Balbir Singh
2016-04-14 15:54 ` Akshay Adiga
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160414021927.GK19433@vireshk-i7 \
--to=viresh.kumar@linaro.org \
--cc=akshay.adiga@linux.vnet.ibm.com \
--cc=ego@linux.vnet.ibm.com \
--cc=linux-pm@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox