From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from e28smtp08.in.ibm.com (e28smtp08.in.ibm.com [125.16.236.8]) (using TLSv1.2 with cipher CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3qlq0G3ShYzDq5y for ; Thu, 14 Apr 2016 15:26:22 +1000 (AEST) Received: from localhost by e28smtp08.in.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 14 Apr 2016 10:56:19 +0530 Received: from d28av05.in.ibm.com (d28av05.in.ibm.com [9.184.220.67]) by d28relay01.in.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id u3E5QDkC30933080 for ; Thu, 14 Apr 2016 10:56:14 +0530 Received: from d28av05.in.ibm.com (localhost [127.0.0.1]) by d28av05.in.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id u3E5Q7Oc008199 for ; Thu, 14 Apr 2016 10:56:13 +0530 Date: Thu, 14 Apr 2016 15:25:56 +1000 From: Gavin Shan To: Alexey Kardashevskiy Cc: Gavin Shan , linuxppc-dev@lists.ozlabs.org, linux-pci@vger.kernel.org, devicetree@vger.kernel.org, benh@kernel.crashing.org, mpe@ellerman.id.au, dja@axtens.net, bhelgaas@google.com, robherring2@gmail.com, grant.likely@linaro.org Subject: Re: [PATCH v8 00/45] powerpc/powernv: PCI hotplug support Message-ID: <20160414052556.GA7402@gwshan> Reply-To: Gavin Shan References: <1455680668-23298-1-git-send-email-gwshan@linux.vnet.ibm.com> <570DF50F.6010805@ozlabs.ru> <20160413074236.GA28853@gwshan> <570E0E13.6080409@ozlabs.ru> <20160413234246.GA5330@gwshan> <570F0DFB.9090509@ozlabs.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <570F0DFB.9090509@ozlabs.ru> List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Thu, Apr 14, 2016 at 01:26:51PM +1000, Alexey Kardashevskiy wrote: .../... >> >>Do you mean physically pull the adapter out and insert the same >>adapter back? What's the point for the test case? > > >Because this is what the patchset is for - to replace a physical device on a >physical machine. Powering on/off the slots via sysfs is just an >approximation (which is fine when you are debugging), something can go wrong >and require some work but you do not know it for sure. > Yes, It's absolutely worthy to be covered by the test cases though case (2) covers part of that. Anyway, I'll test it through in next revision. Thanks for your review. > > >-- >Alexey >