From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf0-x235.google.com (mail-pf0-x235.google.com [IPv6:2607:f8b0:400e:c00::235]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3qpPHt6rb1zDq60 for ; Mon, 18 Apr 2016 20:18:50 +1000 (AEST) Received: by mail-pf0-x235.google.com with SMTP id e128so79379455pfe.3 for ; Mon, 18 Apr 2016 03:18:50 -0700 (PDT) Date: Mon, 18 Apr 2016 15:48:46 +0530 From: Viresh Kumar To: Akshay Adiga Cc: rjw@rjwysocki.net, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, ego@linux.vnet.ibm.com Subject: Re: [PATCH v2 2/2] cpufreq: powernv: Ramp-down global pstate slower than local-pstate Message-ID: <20160418101846.GB2322@vireshk-i7> References: <1460701739-31549-1-git-send-email-akshay.adiga@linux.vnet.ibm.com> <1460701739-31549-3-git-send-email-akshay.adiga@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <1460701739-31549-3-git-send-email-akshay.adiga@linux.vnet.ibm.com> List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On 15-04-16, 11:58, Akshay Adiga wrote: > static int powernv_cpufreq_reboot_notifier(struct notifier_block *nb, > - unsigned long action, void *unused) > + unsigned long action, void *unused) Unrelated change.. better don't add such changes.. > { > int cpu; > struct cpufreq_policy cpu_policy; > @@ -603,15 +843,18 @@ static struct notifier_block powernv_cpufreq_opal_nb = { > static void powernv_cpufreq_stop_cpu(struct cpufreq_policy *policy) > { > struct powernv_smp_call_data freq_data; > - > + struct global_pstate_info *gpstates = policy->driver_data; You removed a blank line here and I feel the code looks better with that. > freq_data.pstate_id = powernv_pstate_info.min; > + freq_data.gpstate_id = powernv_pstate_info.min; > smp_call_function_single(policy->cpu, set_pstate, &freq_data, 1); > + del_timer_sync(&gpstates->timer); > } > > static struct cpufreq_driver powernv_cpufreq_driver = { > .name = "powernv-cpufreq", > .flags = CPUFREQ_CONST_LOOPS, > .init = powernv_cpufreq_cpu_init, > + .exit = powernv_cpufreq_cpu_exit, > .verify = cpufreq_generic_frequency_table_verify, > .target_index = powernv_cpufreq_target_index, > .get = powernv_cpufreq_get, None of the above comments are mandatory for you to fix.. Acked-by: Viresh Kumar -- viresh