From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pa0-x230.google.com (mail-pa0-x230.google.com [IPv6:2607:f8b0:400e:c03::230]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3qpPd94qWXzDqBy for ; Mon, 18 Apr 2016 20:33:49 +1000 (AEST) Received: by mail-pa0-x230.google.com with SMTP id zm5so77898522pac.0 for ; Mon, 18 Apr 2016 03:33:49 -0700 (PDT) Date: Mon, 18 Apr 2016 16:03:45 +0530 From: Viresh Kumar To: Jia Hongtao Cc: linux-pm@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, scott.wood@nxp.com, yuantian.tang@nxp.com Subject: Re: [PATCH 2/2] cpufreq: qoriq: Don't show cooling device messages if THERMAL_OF undefined Message-ID: <20160418103345.GE2322@vireshk-i7> References: <1460966372-4877-1-git-send-email-hongtao.jia@nxp.com> <1460966372-4877-2-git-send-email-hongtao.jia@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <1460966372-4877-2-git-send-email-hongtao.jia@nxp.com> List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On 18-04-16, 15:59, Jia Hongtao wrote: > When THERMAL_OF is undefined the cooling device messages should not be > shown. -ENOSYS is returned from of_cpufreq_cooling_register() when > THERMAL_OF is undefined. > > Signed-off-by: Jia Hongtao > --- > drivers/cpufreq/qoriq-cpufreq.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/cpufreq/qoriq-cpufreq.c b/drivers/cpufreq/qoriq-cpufreq.c > index 1c2fdc1..ff8da83 100644 > --- a/drivers/cpufreq/qoriq-cpufreq.c > +++ b/drivers/cpufreq/qoriq-cpufreq.c > @@ -340,8 +340,8 @@ static void qoriq_cpufreq_ready(struct cpufreq_policy *policy) > cpud->cdev = of_cpufreq_cooling_register(np, > policy->related_cpus); > > - if (IS_ERR(cpud->cdev)) { > - pr_err("Failed to register cooling device cpu%d: %ld\n", > + if (IS_ERR(cpud->cdev) && PTR_ERR(cpud->cdev) != -ENOSYS) { > + pr_err("cpu%d is not running as cooling device: %ld\n", > policy->cpu, PTR_ERR(cpud->cdev)); > > cpud->cdev = NULL; Acked-by: Viresh Kumar -- viresh