From: Gavin Shan <gwshan@linux.vnet.ibm.com>
To: Russell Currey <ruscur@russell.cc>
Cc: Gavin Shan <gwshan@linux.vnet.ibm.com>,
linuxppc-dev@lists.ozlabs.org, alistair@popple.id.au,
david@gibson.dropbear.id.au, mpe@ellerman.id.au
Subject: Re: [PATCH 2/3] powerpc/eeh: Restore config from edev in eeh_pe_reset_and_recover()
Date: Fri, 22 Apr 2016 23:17:19 +1000 [thread overview]
Message-ID: <20160422131719.GA31375@gwshan> (raw)
In-Reply-To: <1461307072.2646.4.camel@russell.cc>
On Fri, Apr 22, 2016 at 04:37:52PM +1000, Russell Currey wrote:
>On Thu, 2016-04-21 at 21:53 +1000, Gavin Shan wrote:
>> The function eeh_pe_reset_and_recover() is used to recover EEH
>> error when the passthrou device are transferred to guest and
>> backwords. The content in the device's config space will be lost
>
>Spelling, as before :)
>
>> on PE reset issued in the middle of the recovery. The function
>> saves/restores it before/after the reset. However, config access
>> to some adapters like Broadcom BCM5719 at this point will causes
>> fended PHB. The config space is always blocked and we save 0xFF's
>
>"fended" should be "fenced"
>
Thanks, Russell. I'll fix it in next revision ;-)
>> that are restored at late point. The memory BARs are totally
>> corrupted, causing another EEH error upon access to one of the
>> memory BARs.
>>
>> This restores the config space from the content saved to the
>> EEH device when it's populated, to resolve above issue.
>>
>> Fixes: 5cfb20b9 ("powerpc/eeh: Emulate EEH recovery for VFIO devices")
>> Cc: stable@vger.kernel.org #v3.18+
>> Signed-off-by: Gavin Shan <gwshan@linux.vnet.ibm.com>
>> ---
>
>Reviewed-by: Russell Currey <ruscur@russell.cc>
>
next prev parent reply other threads:[~2016-04-22 13:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-21 11:53 [PATCH 1/3] powerpc/eeh: Ignore error handlers in eeh_pe_reset_and_recover() Gavin Shan
2016-04-21 11:53 ` [PATCH 2/3] powerpc/eeh: Restore config from edev " Gavin Shan
2016-04-22 6:37 ` Russell Currey
2016-04-22 13:17 ` Gavin Shan [this message]
2016-04-21 11:53 ` [PATCH 3/3] powerpc/eeh: Drop unnecessary label in eeh_pe_change_owner() Gavin Shan
2016-04-22 5:15 ` David Gibson
2016-04-22 6:38 ` Russell Currey
2016-04-22 13:17 ` Gavin Shan
2016-04-22 6:35 ` [PATCH 1/3] powerpc/eeh: Ignore error handlers in eeh_pe_reset_and_recover() Russell Currey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160422131719.GA31375@gwshan \
--to=gwshan@linux.vnet.ibm.com \
--cc=alistair@popple.id.au \
--cc=david@gibson.dropbear.id.au \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=ruscur@russell.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).