From: Alex Williamson <alex.williamson@redhat.com>
To: Alexey Kardashevskiy <aik@ozlabs.ru>
Cc: linuxppc-dev@lists.ozlabs.org,
David Gibson <david@gibson.dropbear.id.au>,
kvm@vger.kernel.org
Subject: Re: [PATCH kernel] vfio_iommu_spapr_tce: Remove unneeded iommu_group_get_iommudata
Date: Thu, 28 Apr 2016 12:33:00 -0600 [thread overview]
Message-ID: <20160428123300.34dfff51@t450s.home> (raw)
In-Reply-To: <1460091281-14664-1-git-send-email-aik@ozlabs.ru>
On Fri, 8 Apr 2016 14:54:41 +1000
Alexey Kardashevskiy <aik@ozlabs.ru> wrote:
> This removes iommu_group_get_iommudata() as the result is never used.
> As this is a minor cleanup, no change in behavior is expected.
>
> Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
> ---
> drivers/vfio/vfio_iommu_spapr_tce.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/vfio/vfio_iommu_spapr_tce.c b/drivers/vfio/vfio_iommu_spapr_tce.c
> index 0582b72..6419566 100644
> --- a/drivers/vfio/vfio_iommu_spapr_tce.c
> +++ b/drivers/vfio/vfio_iommu_spapr_tce.c
> @@ -331,14 +331,12 @@ static void tce_iommu_free_table(struct iommu_table *tbl);
> static void tce_iommu_release(void *iommu_data)
> {
> struct tce_container *container = iommu_data;
> - struct iommu_table_group *table_group;
> struct tce_iommu_group *tcegrp;
> long i;
>
> while (tce_groups_attached(container)) {
> tcegrp = list_first_entry(&container->group_list,
> struct tce_iommu_group, next);
> - table_group = iommu_group_get_iommudata(tcegrp->grp);
> tce_iommu_detach_group(iommu_data, tcegrp->grp);
> }
>
Applied to next with David's R-b for v4.7. Thanks,
Alex
prev parent reply other threads:[~2016-04-28 18:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-08 4:54 [PATCH kernel] vfio_iommu_spapr_tce: Remove unneeded iommu_group_get_iommudata Alexey Kardashevskiy
2016-04-08 5:00 ` David Gibson
2016-04-28 18:33 ` Alex Williamson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160428123300.34dfff51@t450s.home \
--to=alex.williamson@redhat.com \
--cc=aik@ozlabs.ru \
--cc=david@gibson.dropbear.id.au \
--cc=kvm@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).