From: Paul Mackerras <paulus@ozlabs.org>
To: Alexander Graf <agraf@suse.de>
Cc: Madhavan Srinivasan <maddy@linux.vnet.ibm.com>,
Thomas Huth <thuth@redhat.com>,
Michael Ellerman <mpe@ellerman.id.au>,
linuxppc-dev@lists.ozlabs.org, kvm-ppc@vger.kernel.org
Subject: Re: [PATCH] powerpc: Fix definition of SIAR register
Date: Thu, 12 May 2016 14:57:56 +1000 [thread overview]
Message-ID: <20160512045756.GB1421@oak.ozlabs.ibm.com> (raw)
In-Reply-To: <182287E9-40B9-4774-A932-08A0AA499AE3@suse.de>
On Mon, Apr 25, 2016 at 10:15:47AM +0200, Alexander Graf wrote:
>
> >> +#define SPRN_SIAR 796
>
> I'm sure there's a reason (iSeries?) we used the r/o version before. Better introduce a new constant that gives us rw access and use that in the kvm entry/exit code.
I don't think we ever did any performance monitoring on iSeries, and
in any case, we have removed the iSeries code. I think we should just
use the privileged, read/write number (i.e. 796).
Paul.
next prev parent reply other threads:[~2016-05-12 4:58 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-08 15:54 [PATCH] powerpc: Fix definition of SIAR register Thomas Huth
2016-04-25 6:50 ` Thomas Huth
2016-04-25 8:08 ` Madhavan Srinivasan
2016-04-25 8:15 ` Alexander Graf
2016-04-25 9:16 ` Thomas Huth
2016-04-25 9:31 ` Alexander Graf
2016-04-25 11:15 ` Madhavan Srinivasan
2016-05-12 4:57 ` Paul Mackerras [this message]
2016-05-12 7:27 ` Thomas Huth
2016-05-12 10:40 ` Paul Mackerras
2016-05-12 4:51 ` Paul Mackerras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160512045756.GB1421@oak.ozlabs.ibm.com \
--to=paulus@ozlabs.org \
--cc=agraf@suse.de \
--cc=kvm-ppc@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=maddy@linux.vnet.ibm.com \
--cc=mpe@ellerman.id.au \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).