From: Gavin Shan <gwshan@linux.vnet.ibm.com>
To: Alexey Kardashevskiy <aik@ozlabs.ru>
Cc: linuxppc-dev@lists.ozlabs.org,
Alistair Popple <alistair@popple.id.au>,
Gavin Shan <gwshan@linux.vnet.ibm.com>,
Michael Ellerman <mpe@ellerman.id.au>,
Paul Mackerras <paulus@samba.org>
Subject: Re: [PATCH kernel 2/2] powerpc/powernv/npu: Add PE to PHB's list
Date: Thu, 12 May 2016 16:15:35 +1000 [thread overview]
Message-ID: <20160512061535.GA5956@gwshan> (raw)
In-Reply-To: <1463032030-38974-3-git-send-email-aik@ozlabs.ru>
On Thu, May 12, 2016 at 03:47:10PM +1000, Alexey Kardashevskiy wrote:
>Before 3e68dc57 "powerpc/powernv: Remove DMA32 PE list", NPU PEs
>were linked to the NPU PHB via phb->ioda.pe_dma_list; after that fix,
>the phb->ioda.pe_list is used.
>
>During the pe_dma_list removal, list_add_tail(&phb->ioda.pe_dma_list)
>was removed, however no list_add() was added so does this patch.
>
>Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
Reviewed-by: Gavin Shan <gwshan@linux.vnet.ibm.com>
>---
> arch/powerpc/platforms/powernv/pci-ioda.c | 3 +++
> 1 file changed, 3 insertions(+)
>
>diff --git a/arch/powerpc/platforms/powernv/pci-ioda.c b/arch/powerpc/platforms/powernv/pci-ioda.c
>index d0d32c2..4f9e73a 100644
>--- a/arch/powerpc/platforms/powernv/pci-ioda.c
>+++ b/arch/powerpc/platforms/powernv/pci-ioda.c
>@@ -1009,6 +1009,9 @@ static struct pnv_ioda_pe *pnv_ioda_setup_dev_PE(struct pci_dev *dev)
> return NULL;
> }
>
>+ /* Put PE to the list */
>+ list_add_tail(&pe->list, &phb->ioda.pe_list);
>+
> return pe;
> }
>
>--
>2.5.0.rc3
>
next prev parent reply other threads:[~2016-05-12 6:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-12 5:47 [PATCH kernel 0/2] powerpc/powernv/npu: Fixes for next tree Alexey Kardashevskiy
2016-05-12 5:47 ` [PATCH kernel 1/2] powerpc/powernv: Fix insufficient memory allocation Alexey Kardashevskiy
2016-05-12 6:09 ` Gavin Shan
2016-05-12 6:39 ` Alexey Kardashevskiy
2016-05-12 6:59 ` Gavin Shan
2016-05-12 11:32 ` [kernel,1/2] " Michael Ellerman
2016-05-12 5:47 ` [PATCH kernel 2/2] powerpc/powernv/npu: Add PE to PHB's list Alexey Kardashevskiy
2016-05-12 6:15 ` Gavin Shan [this message]
2016-05-12 11:32 ` [kernel,2/2] " Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160512061535.GA5956@gwshan \
--to=gwshan@linux.vnet.ibm.com \
--cc=aik@ozlabs.ru \
--cc=alistair@popple.id.au \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).