From: Masami Hiramatsu <mhiramat@kernel.org>
To: Anju T <anju@linux.vnet.ibm.com>
Cc: linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
ananth@in.ibm.com, naveen.n.rao@linux.vnet.ibm.com,
paulus@samba.org, masami.hiramatsu.pt@hitachi.com,
jkenisto@us.ibm.com, srikar@linux.vnet.ibm.com,
benh@kernel.crashing.org, mpe@ellerman.id.au,
hemant@linux.vnet.ibm.com, mahesh@linux.vnet.ibm.com
Subject: Re: [RFC PATCH 2/3] arch/powerpc : optprobes for powerpc core
Date: Fri, 20 May 2016 20:35:15 +0900 [thread overview]
Message-ID: <20160520203515.d1e2e752f59fcc3d3e72e69c@kernel.org> (raw)
In-Reply-To: <573D7016.2050900@linux.vnet.ibm.com>
On Thu, 19 May 2016 13:19:42 +0530
Anju T <anju@linux.vnet.ibm.com> wrote:
> >> +void arch_unoptimize_kprobes(struct list_head *oplist,
> >> + struct list_head *done_list)
> >> +{
> >> + struct optimized_kprobe *op;
> >> + struct optimized_kprobe *tmp;
> >> +
> >> + list_for_each_entry_safe(op, tmp, oplist, list) {
> >> + arch_unoptimize_kprobe(op);
> >> + list_move(&op->list, done_list);
> >> + }
> >> +}
> >> +
> >> +int arch_within_optimized_kprobe(struct optimized_kprobe *op,
> >> + unsigned long addr)
> >> +{
> > Please make sure addr != op->kp.addr and addr is aligned.
>
> The only case this check will succeed is if kp.addr is not a multiple of 4, which is not a valid address at all on
> Power.So should we again check here for that?
Ah, right. OK, so we may not need that.
Thank you,
--
Masami Hiramatsu <mhiramat@kernel.org>
next prev parent reply other threads:[~2016-05-20 11:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-17 20:39 [RFC PATCH 0/3] OPTPROBES for powerpc Anju T
2016-05-17 20:39 ` [RFC PATCH 1/3] arch/powerpc : Add detour buffer support for optprobes Anju T
2016-05-17 20:39 ` [RFC PATCH 2/3] arch/powerpc : optprobes for powerpc core Anju T
2016-05-18 15:13 ` Masami Hiramatsu
2016-05-19 7:49 ` Anju T
2016-05-20 11:35 ` Masami Hiramatsu [this message]
2016-05-17 20:39 ` [RFC PATCH 3/3] arch/powerpc : Enable optprobes support in powerpc Anju T
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160520203515.d1e2e752f59fcc3d3e72e69c@kernel.org \
--to=mhiramat@kernel.org \
--cc=ananth@in.ibm.com \
--cc=anju@linux.vnet.ibm.com \
--cc=benh@kernel.crashing.org \
--cc=hemant@linux.vnet.ibm.com \
--cc=jkenisto@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mahesh@linux.vnet.ibm.com \
--cc=masami.hiramatsu.pt@hitachi.com \
--cc=mpe@ellerman.id.au \
--cc=naveen.n.rao@linux.vnet.ibm.com \
--cc=paulus@samba.org \
--cc=srikar@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).