linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Paul Mackerras <paulus@ozlabs.org>
To: Andrea Gelmini <andrea.gelmini@gelma.net>
Cc: trivial@kernel.org, benh@kernel.crashing.org, mpe@ellerman.id.au,
	christophe.leroy@c-s.fr, oss@buserror.net,
	linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH 0228/1529] Fix typo
Date: Sun, 22 May 2016 12:37:32 +1000	[thread overview]
Message-ID: <20160522023732.GA23547@fergus.ozlabs.ibm.com> (raw)
In-Reply-To: <20160521120618.11846-1-andrea.gelmini@gelma.net>

On Sat, May 21, 2016 at 02:06:18PM +0200, Andrea Gelmini wrote:
> Signed-off-by: Andrea Gelmini <andrea.gelmini@gelma.net>
> ---
>  arch/powerpc/lib/checksum_64.S | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/powerpc/lib/checksum_64.S b/arch/powerpc/lib/checksum_64.S
> index 8e6e510..f3b5b7d 100644
> --- a/arch/powerpc/lib/checksum_64.S
> +++ b/arch/powerpc/lib/checksum_64.S
> @@ -74,7 +74,7 @@ _GLOBAL(__csum_partial)
>  	ld	r11,24(r3)
>  
>  	/*
> -	 * On POWER6 and POWER7 back to back addes take 2 cycles because of
> +	 * On POWER6 and POWER7 back to back adds take 2 cycles because of
>  	 * the XER dependency. This means the fastest this loop can go is
>  	 * 16 cycles per iteration. The scheduling of the loop below has
>  	 * been shown to hit this on both POWER6 and POWER7.
> @@ -275,7 +275,7 @@ source;	ld	r10,16(r3)
>  source;	ld	r11,24(r3)
>  
>  	/*
> -	 * On POWER6 and POWER7 back to back addes take 2 cycles because of
> +	 * On POWER6 and POWER7 back to back adds take 2 cycles because of
>  	 * the XER dependency. This means the fastest this loop can go is
>  	 * 16 cycles per iteration. The scheduling of the loop below has
>  	 * been shown to hit this on both POWER6 and POWER7.

NAK - this is talking about the 'adde' instruction, not the 'add'
instruction.

Paul.

  reply	other threads:[~2016-05-22 12:39 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-21 12:06 [PATCH 0228/1529] Fix typo Andrea Gelmini
2016-05-22  2:37 ` Paul Mackerras [this message]
2016-05-23  1:27   ` [PATCH] Clarify that adde is an instruction and we mean plural Stewart Smith
2016-07-17 10:28     ` Michael Ellerman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160522023732.GA23547@fergus.ozlabs.ibm.com \
    --to=paulus@ozlabs.org \
    --cc=andrea.gelmini@gelma.net \
    --cc=benh@kernel.crashing.org \
    --cc=christophe.leroy@c-s.fr \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mpe@ellerman.id.au \
    --cc=oss@buserror.net \
    --cc=trivial@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).