From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3rNpdP4hQtzDqG1 for ; Tue, 7 Jun 2016 08:04:25 +1000 (AEST) Received: from pps.filterd (m0049461.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.11/8.16.0.11) with SMTP id u56Lx9H4038692 for ; Mon, 6 Jun 2016 18:04:21 -0400 Message-Id: <201606062204.u56Lx9H4038692@mx0a-001b2d01.pphosted.com> Received: from e24smtp04.br.ibm.com (e24smtp04.br.ibm.com [32.104.18.25]) by mx0b-001b2d01.pphosted.com with ESMTP id 23dcu8j2kc-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Mon, 06 Jun 2016 18:04:21 -0400 Received: from localhost by e24smtp04.br.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 6 Jun 2016 19:04:19 -0300 Received: from d24relay02.br.ibm.com (d24relay02.br.ibm.com [9.13.184.26]) by d24dlp02.br.ibm.com (Postfix) with ESMTP id 44B1C1DC006F for ; Mon, 6 Jun 2016 18:04:09 -0400 (EDT) Received: from d24av04.br.ibm.com (d24av04.br.ibm.com [9.8.31.97]) by d24relay02.br.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id u56M4Gj333947908 for ; Mon, 6 Jun 2016 19:04:16 -0300 Received: from d24av04.br.ibm.com (localhost [127.0.0.1]) by d24av04.br.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id u56M4Fgg011742 for ; Mon, 6 Jun 2016 19:04:16 -0300 Subject: Re: [PATCH v2] powerpc: export cpu_to_core_id() To: Mauricio Faria de Oliveira References: <201606021145.u52Behar021447@mx0a-001b2d01.pphosted.com> Cc: linuxppc-dev@lists.ozlabs.org, mpe@ellerman.id.au From: "Guilherme G. Piccoli" Date: Mon, 6 Jun 2016 19:04:15 -0300 MIME-Version: 1.0 In-Reply-To: <201606021145.u52Behar021447@mx0a-001b2d01.pphosted.com> Content-Type: text/plain; charset=utf-8; format=flowed List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On 06/02/2016 08:45 AM, Mauricio Faria de Oliveira wrote: > Export cpu_to_core_id(). This will be used by the lpfc driver. > > This enables topology_core_id() from (defined > to cpu_to_core_id() in arch/powerpc/include/asm/topology.h) to be > used by (non-builtin) modules. > > That is arch-neutral, already used by eg, drivers/base/topology.c, > but it is builtin (obj-y in Makefile) thus didn't need the export. > > Since the module uses topology_core_id() and this is defined to > cpu_to_core_id(), it needs the export, otherwise: > > ERROR: "cpu_to_core_id" [drivers/scsi/lpfc/lpfc.ko] undefined! > make[1]: *** [__modpost] Error 1 > make: *** [modules] Error 2 > > Tested on next-20160601. > > Changelog: > - v2: include details about the need for this patch with regards > to the architecture-neutral topology API. > > Signed-off-by: Mauricio Faria de Oliveira > --- > arch/powerpc/kernel/smp.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/powerpc/kernel/smp.c b/arch/powerpc/kernel/smp.c > index 55c924b..67136e7 100644 > --- a/arch/powerpc/kernel/smp.c > +++ b/arch/powerpc/kernel/smp.c > @@ -593,6 +593,7 @@ out: > of_node_put(np); > return id; > } > +EXPORT_SYMBOL_GPL(cpu_to_core_id); > > /* Helper routines for cpu to core mapping */ > int cpu_core_index_of_thread(int cpu) > Hi Maurício, I'm planning to use this in another driver heheh Thanks for exporting the symbol. I built a kernel with your patch and it's working fine, so you can add: "Tested-by: Guilherme G. Piccoli " Cheers, Guilherme