From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3rPnvn3xR6zDqHw for ; Wed, 8 Jun 2016 22:35:17 +1000 (AEST) Date: Wed, 8 Jun 2016 14:35:07 +0200 From: Peter Zijlstra To: Michael Ellerman Cc: linuxppc-dev@lists.ozlabs.org, Linux Kernel Mailing List , Benjamin Herrenschmidt , Paul Mackerras , "Paul E. McKenney" , Will Deacon , Boqun Feng Subject: Re: [PATCH v3] powerpc: spinlock: Fix spin_unlock_wait() Message-ID: <20160608123507.GR30154@twins.programming.kicks-ass.net> References: <1465213340.2658.1.camel@ellerman.id.au> <20160606115655.GD30909@twins.programming.kicks-ass.net> <1465215445.2658.4.camel@ellerman.id.au> <20160606144659.GG30909@twins.programming.kicks-ass.net> <1465384845.13854.7.camel@ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <1465384845.13854.7.camel@ellerman.id.au> List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Wed, Jun 08, 2016 at 09:20:45PM +1000, Michael Ellerman wrote: > On Mon, 2016-06-06 at 16:46 +0200, Peter Zijlstra wrote: > > On Mon, Jun 06, 2016 at 10:17:25PM +1000, Michael Ellerman wrote: > > > On Mon, 2016-06-06 at 13:56 +0200, Peter Zijlstra wrote: > > > > On Mon, Jun 06, 2016 at 09:42:20PM +1000, Michael Ellerman wrote: > > > > > > > > Why the move to in-line this implementation? It looks like a fairly big > > > > function. > > > > > > I agree it's not pretty. > > > > > I'm not beholden to v3 though if you hate it. > > > > I don't mind; its just that I am in a similar boat with qspinlock and > > chose the other option. So I just figured I'd ask :-) > > OK. I'll go with inline and we'll see which version gets "cleaned-up" by a > janitor first ;) Ok; what tree does this go in? I have this dependent series which I'd like to get sorted and merged somewhere.