From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3rgNDx1FzDzDr3B for ; Fri, 1 Jul 2016 01:07:12 +1000 (AEST) Date: Thu, 30 Jun 2016 11:07:00 -0400 From: Dave Young To: Thiago Jung Bauermann Cc: kexec@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, Eric Biederman Subject: Re: [PATCH v3 2/9] kexec_file: Generalize kexec_add_buffer. Message-ID: <20160630150700.GA3058@dhcp-128-65.nay.redhat.com> References: <1466538521-31216-1-git-send-email-bauerman@linux.vnet.ibm.com> <2060648.f0n9OPAato@hactar> <20160629194751.GB5488@dhcp-128-65.nay.redhat.com> <1994502.0E8c14rYFh@hactar> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <1994502.0E8c14rYFh@hactar> List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On 06/29/16 at 06:18pm, Thiago Jung Bauermann wrote: > Am Mittwoch, 29 Juni 2016, 15:47:51 schrieb Dave Young: > > On 06/28/16 at 07:18pm, Thiago Jung Bauermann wrote: > > > diff --git a/include/linux/kexec.h b/include/linux/kexec.h > > > index e8acb2b43dd9..e16d845d587f 100644 > > > --- a/include/linux/kexec.h > > > +++ b/include/linux/kexec.h > > > @@ -146,7 +146,30 @@ struct kexec_file_ops { > > > > > > kexec_verify_sig_t *verify_sig; > > > > > > #endif > > > }; > > > > > > -#endif > > > + > > > +/** > > > + * struct kexec_buf - parameters for finding a place for a buffer in > > > memory + * @image: kexec image in which memory to search. > > > + * @mem: On return will have address of the buffer in memory. > > > + * @memsz: Size for the buffer in memory. > > > + * @buf_align: Minimum alignment needed. > > > + * @buf_min: The buffer can't be placed below this address. > > > + * @buf_max: The buffer can't be placed above this address. > > > + * @top_down: Allocate from top of memory. > > > + */ > > > +struct kexec_buf { > > > + struct kimage *image; > > > + unsigned long mem; > > > + unsigned long memsz; > > > + unsigned long buf_align; > > > + unsigned long buf_min; > > > + unsigned long buf_max; > > > + bool top_down; > > > +}; > > > > Rethink about the first patch, you dropped the user buffer in kexec_buf > > But later your passing IMA digests buffer patchset may need use it. > > > > So keep it in kexec_buf should be better. > > I'm not following. The IMA buffer patchset doesn't use kexec_locate_mem_hole > nor struct kexec_buf. It does not use kexec_locate_mem_hole, but the buffer being passed is very similar to a kexec_buf struct, no? So you may refactor kexec_add_buffer and your new function to pass only kimage and a kbuf, it will be better than passing all those arguments separately. > > > For the IMA buffer patchset I'm still reading and learning the > > background, will reply them later. > > Thank you! > > []'s > Thiago Jung Bauermann > IBM Linux Technology Center > Thanks Dave