From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3rgXvS4J8BzDqhC for ; Fri, 1 Jul 2016 07:37:40 +1000 (AEST) Date: Thu, 30 Jun 2016 17:37:25 -0400 From: Dave Young To: Thiago Jung Bauermann Cc: linuxppc-dev@lists.ozlabs.org, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, vgoyal@redhat.com, Eric Biederman Subject: Re: [PATCH v3 3/9] kexec_file: Factor out kexec_locate_mem_hole from kexec_add_buffer. Message-ID: <20160630213725.GA4187@dhcp-128-65.nay.redhat.com> References: <1466538521-31216-1-git-send-email-bauerman@linux.vnet.ibm.com> <1736656.LVyt5NrzWE@hactar> <20160630154119.GB3058@dhcp-128-65.nay.redhat.com> <1786832.5GOvNa6ecY@hactar> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <1786832.5GOvNa6ecY@hactar> List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On 06/30/16 at 01:08pm, Thiago Jung Bauermann wrote: > Am Donnerstag, 30 Juni 2016, 11:41:19 schrieb Dave Young: > > On 06/29/16 at 06:09pm, Thiago Jung Bauermann wrote: > > > Am Mittwoch, 29 Juni 2016, 15:45:18 schrieb Dave Young: > > > > On 06/28/16 at 07:18pm, Thiago Jung Bauermann wrote: > > > > > Am Dienstag, 28 Juni 2016, 15:20:55 schrieb Dave Young: > > > > > > On 06/27/16 at 04:21pm, Dave Young wrote: > > > > It looks good except one nitpick inline.. > > > > > > > > > +/** > > > > > + * kexec_locate_mem_hole - find free memory to load segment or use > > > > > in > > > > > purgatory > > > > > > > > It is not necessary to use only for purgatory load.. > > > > > > Ok, what about this? > > > > > > /** > > > > > > * kexec_locate_mem_hole - find free memory in a given kimage. > > > > Hmm, a given kimage sounds not correct, I can not get a better way to > > describe it. How about below with a little change to your previous one: > > > > kexec_locate_mem_hole - find a free chunk of memory to load kexec segment. > > In powerpc the memory chunk can also be used for the purgatory stack. > > That describes what the memory currently is used for. If powerpc or any > other architecture starts to use the memory for something else, this comment > would need to be updated. :-) > > What the function really does is find free memory in the physical address > space after the currently running kernel hands over control to whatever runs > next. What that memory is used for is decided by the caller of the function. > > Since (at least for now), the only things that run next are the purgatory > and the next kernel, what about this? > > kexec_locate_mem_hole - find free memory for the purgatory or the next > kernel Ok, I'm fine with above version. Thanks Dave