From: Jason Cooper <jason@lakedaemon.net>
To: Zhao Qiang <qiang.zhao@nxp.com>
Cc: oss@buserror.net, tglx@linutronix.de, marc.zyngier@arm.com,
linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,
xiaobo.xie@nxp.com
Subject: Re: [PATCH v2] irqchip/qeic: move qeic driver from drivers/soc/fsl/qe
Date: Thu, 7 Jul 2016 14:24:58 +0000 [thread overview]
Message-ID: <20160707142458.GN3348@io.lakedaemon.net> (raw)
In-Reply-To: <1467854635-19208-1-git-send-email-qiang.zhao@nxp.com>
Hi Zhao Qiang,
On Thu, Jul 07, 2016 at 09:23:55AM +0800, Zhao Qiang wrote:
> The driver stays the same.
>
> Signed-off-by: Zhao Qiang <qiang.zhao@nxp.com>
> ---
> Changes for v2:
> - modify the subject and commit msg
>
> drivers/irqchip/Makefile | 1 +
> drivers/{soc/fsl/qe => irqchip}/qe_ic.c | 0
> drivers/{soc/fsl/qe => irqchip}/qe_ic.h | 0
> drivers/soc/fsl/qe/Makefile | 2 +-
> 4 files changed, 2 insertions(+), 1 deletion(-)
> rename drivers/{soc/fsl/qe => irqchip}/qe_ic.c (100%)
> rename drivers/{soc/fsl/qe => irqchip}/qe_ic.h (100%)
Please merge the include file into the C file and rename to follow the
naming convention in drivers/irqchip/. e.g. irq-qeic.c or irq-qe_ic.c.
Once you have that, please resend the entire series with this as the
first patch.
thx,
Jason.
next prev parent reply other threads:[~2016-07-07 14:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-07 1:23 [PATCH v2] irqchip/qeic: move qeic driver from drivers/soc/fsl/qe Zhao Qiang
2016-07-07 14:24 ` Jason Cooper [this message]
2016-07-08 1:04 ` Qiang Zhao
2016-07-25 6:15 ` Qiang Zhao
2016-07-25 7:05 ` Scott Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160707142458.GN3348@io.lakedaemon.net \
--to=jason@lakedaemon.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=marc.zyngier@arm.com \
--cc=oss@buserror.net \
--cc=qiang.zhao@nxp.com \
--cc=tglx@linutronix.de \
--cc=xiaobo.xie@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).