From: David Miller <davem@davemloft.net>
To: arvind.yadav.cs@gmail.com
Cc: leoli@freescale.com, netdev@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Need proper type casting before assignment, Remove compilation Warning.
Date: Sat, 09 Jul 2016 18:06:40 -0400 (EDT) [thread overview]
Message-ID: <20160709.180640.648031801699853376.davem@davemloft.net> (raw)
In-Reply-To: <1467916674-8418-1-git-send-email-arvind.yadav.cs@gmail.com>
From: Arvind Yadav <arvind.yadav.cs@gmail.com>
Date: Fri, 8 Jul 2016 00:07:54 +0530
> -Return type of 'qe_muram_alloc' is 'unsigned long', That Was trying to
> assigned in ucc_fast_tx_virtual_fifo_base_offset and
> ucc_fast_rx_virtual_fifo_base_offset. These variable are 'unsigned int'.
> So before assginment need a proper type casting.
>
> -Passing value in IS_ERR_VALUE() is wrong, as they pass an 'int'
> into a function that takes an 'unsigned long' argument.This happens
> to work because the type is sign-extended on 64-bit architectures
> before it gets converted into an unsigned type.
>
> -Passing an 'unsigned short' or 'unsigned int'argument into
> IS_ERR_VALUE() is guaranteed to be broken, as are 8-bit integers
> and types that are wider than 'unsigned long'.
>
> -Any user will get compilation warning for that do not pass an
> unsigned long' argument.
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Your subject line is improperly formed.
It must have the subsystem or driver name, followed by a colon ":"
and a space. Such as:
[PATCH] ucc_geth: Need proper type ...
next prev parent reply other threads:[~2016-07-09 22:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-07 18:37 [PATCH] Need proper type casting before assignment, Remove compilation Warning Arvind Yadav
2016-07-08 9:59 ` David Laight
2016-07-09 22:06 ` David Miller [this message]
-- strict thread matches above, loose matches on Subject: below --
2016-07-07 17:01 Arvind Yadav
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160709.180640.648031801699853376.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=arvind.yadav.cs@gmail.com \
--cc=leoli@freescale.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).