From: Gavin Shan <gwshan@linux.vnet.ibm.com>
To: Michael Ellerman <mpe@ellerman.id.au>
Cc: "Guilherme G. Piccoli" <gpiccoli@linux.vnet.ibm.com>,
linuxppc-dev@lists.ozlabs.org, ruscur@russell.cc,
benh@kernel.crashing.org, paulus@samba.org,
gwshan@linux.vnet.ibm.com
Subject: Re: [PATCH] powerpc/eeh: trivial fix to non-conventional PCI address output on EEH log
Date: Mon, 25 Jul 2016 11:46:41 +1000 [thread overview]
Message-ID: <20160725014641.GA21781@gwshan> (raw)
In-Reply-To: <87fuqy1r3i.fsf@concordia.ellerman.id.au>
On Mon, Jul 25, 2016 at 10:47:13AM +1000, Michael Ellerman wrote:
>"Guilherme G. Piccoli" <gpiccoli@linux.vnet.ibm.com> writes:
>
>> This is a very minor/trivial fix for the output of PCI address on EEH logs.
>> The PCI address on "OF node" field currently is using ":" as a separator
>> for the function, but the usual separator is ".". This patch changes the
>> separator for dot, so the PCI address is printed as usual.
>>
>> No functional changes were introduced.
>
>What consumes the log? Can it cope with us changing the formatting?
>
The log is printed by pr_warn() as part of the EEH kernel log. Also,
it's argument passed to RTAS call "ibm,slot-error-detail" and it's
put into the user data section of the RTAS call's output, which is
used by RTAS daemon (rtasd) then. I don't see anyone expects fixed
format for it in the user data section.
The format was ever adjusted in commit 0ed352dddbfc ("powerpc/eeh:
Reduce lines of log dump") on Jul 17 2014. No complains received
against it so far. I guess nobody cares about the format or there
is a alarm isn't raised yet :)
Thanks,
Gavin
next prev parent reply other threads:[~2016-07-25 1:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-22 17:05 [PATCH] powerpc/eeh: trivial fix to non-conventional PCI address output on EEH log Guilherme G. Piccoli
2016-07-25 0:17 ` Gavin Shan
2016-07-25 0:47 ` Michael Ellerman
2016-07-25 1:46 ` Gavin Shan [this message]
2016-07-25 1:54 ` Guilherme G. Piccoli
2016-08-03 13:50 ` Guilherme G. Piccoli
2016-07-25 1:50 ` Guilherme G. Piccoli
2016-08-09 11:26 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160725014641.GA21781@gwshan \
--to=gwshan@linux.vnet.ibm.com \
--cc=benh@kernel.crashing.org \
--cc=gpiccoli@linux.vnet.ibm.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=paulus@samba.org \
--cc=ruscur@russell.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).