From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Michael Ellerman <mpe@ellerman.id.au>
Cc: <linuxppc-dev@ozlabs.org>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>
Subject: Re: [PATCH 1/3] powerpc/mm: Fix build break due when PPC_NATIVE=n
Date: Mon, 25 Jul 2016 14:03:32 +1000 [thread overview]
Message-ID: <20160725140332.0c0b6acd@canb.auug.org.au> (raw)
In-Reply-To: <1469415471-2476-1-git-send-email-mpe@ellerman.id.au>
Hi Michael,
On Mon, 25 Jul 2016 12:57:49 +1000 Michael Ellerman <mpe@ellerman.id.au> wrote:
>
> The recent commit to rework the hash MMU setup broke the build when
> CONFIG_PPC_NATIVE=n. Fix it by providing a fallback implementation of
> hpte_init_native().
Alternatively, you could make the call site dependent on
IS_ENABLED(CONFIG_PPC_NATIVE) and not need the fallback.
so:
else if (IS_ENABLED(CONFIG_PPC_NATIVE))
hpte_init_native();
in arch/powerpc/mm/hash_utils_64.c and let the compiler elide the call.
--
Cheers,
Stephen Rothwell
next prev parent reply other threads:[~2016-07-25 4:03 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-25 2:57 [PATCH 1/3] powerpc/mm: Fix build break due when PPC_NATIVE=n Michael Ellerman
2016-07-25 2:57 ` [PATCH 2/3] powerpc/mm: Rename hpte_init_lpar() & put fallback in a header Michael Ellerman
2016-07-25 4:13 ` Stephen Rothwell
2016-07-25 4:42 ` Benjamin Herrenschmidt
2016-07-25 5:33 ` Michael Ellerman
2016-07-25 9:49 ` Benjamin Herrenschmidt
2016-07-25 10:36 ` Michael Ellerman
2016-07-25 12:11 ` Benjamin Herrenschmidt
2016-07-27 0:27 ` Michael Ellerman
2016-07-25 2:57 ` [PATCH 3/3] powerpc/mm: Drop unused externs for hpte_init_beat[_v3]() Michael Ellerman
2016-07-27 14:32 ` [3/3] " Michael Ellerman
2016-07-25 4:03 ` Stephen Rothwell [this message]
2016-07-25 6:17 ` [PATCH 1/3] powerpc/mm: Fix build break due when PPC_NATIVE=n Michael Ellerman
2016-07-25 10:39 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160725140332.0c0b6acd@canb.auug.org.au \
--to=sfr@canb.auug.org.au \
--cc=benh@kernel.crashing.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=mpe@ellerman.id.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).