From: Nicholas Piggin <npiggin@gmail.com>
To: Michael Ellerman <mpe@ellerman.id.au>
Cc: <linuxppc-dev@ozlabs.org>
Subject: Re: [PATCH 2/2] powerpc/64: Do load of PACAKBASE in LOAD_HANDLER
Date: Tue, 26 Jul 2016 16:36:27 +1000 [thread overview]
Message-ID: <20160726163627.148bbf6a@roar.ozlabs.ibm.com> (raw)
In-Reply-To: <1469510970-11599-2-git-send-email-mpe@ellerman.id.au>
On Tue, 26 Jul 2016 15:29:30 +1000
Michael Ellerman <mpe@ellerman.id.au> wrote:
> The LOAD_HANDLER macro requires that you have previously loaded "reg"
> with PACAKBASE. Although that gives callers flexibility to get
> PACAKBASE in some interesting way, none of the callers actually do
> that. So fold the load of PACAKBASE into the macro, making it simpler
> for callers to use correctly.
>
> Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
I don't see any problem with this.
Reviewed-by: Nick Piggin <npiggin@gmail.com>
next prev parent reply other threads:[~2016-07-26 6:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-26 5:29 [PATCH 1/2] powerpc/64: Correct comment on LOAD_HANDLER() Michael Ellerman
2016-07-26 5:29 ` [PATCH 2/2] powerpc/64: Do load of PACAKBASE in LOAD_HANDLER Michael Ellerman
2016-07-26 6:36 ` Nicholas Piggin [this message]
2016-09-13 12:16 ` [2/2] " Michael Ellerman
2016-07-26 6:17 ` [PATCH 1/2] powerpc/64: Correct comment on LOAD_HANDLER() Nicholas Piggin
2016-09-13 12:16 ` [1/2] " Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160726163627.148bbf6a@roar.ozlabs.ibm.com \
--to=npiggin@gmail.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=mpe@ellerman.id.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).